Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Veterans - Enrollment Success: Add msgid for Veterans copy #1464

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Fix: Veterans - Enrollment Success: Add msgid for Veterans copy #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04fb952
fix(veterans): add va-specific msgid for enrollment success, use in v…
machikoyasuda Jun 28, 2023
66dad36
fix(msgid): add actual copy
machikoyasuda Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions benefits/core/migrations/0002_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,7 @@ def load_data(app, *args, **kwargs):
start_item_secondary_details=_("eligibility.pages.start.veteran.start_item.secondary_details"),
unverified_title=_("eligibility.pages.unverified.title"),
unverified_blurb=_("eligibility.pages.unverified.p[0]"),
enrollment_success_confirm_item_details=_(
"enrollment.pages.index.login_gov.eligibility_confirmed_item.details%(transit_agency_short_name)s"
),
enrollment_success_confirm_item_details=_("enrollment.pages.success.veteran.confirm_item.details"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this msgid was what needed to be fixed.

enrollment_success_expiry_item_heading=None,
enrollment_success_expiry_item_details=None,
)
Expand Down
9 changes: 8 additions & 1 deletion benefits/locale/en/LC_MESSAGES/django.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
msgid ""
msgstr ""
"Report-Msgid-Bugs-To: https://github.com/cal-itp/benefits/issues \n"
"POT-Creation-Date: 2023-06-26 21:25+0000\n"
"POT-Creation-Date: 2023-06-28 22:08+0000\n"
"Language: English\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
Expand Down Expand Up @@ -107,6 +107,13 @@ msgstr ""
"If you do not have an account with any of these services, you will need to "
"create one. We recommend using Login.gov."

msgid "enrollment.pages.success.veteran.confirm_item.details"
msgstr ""
"You were not charged anything today. When boarding transit, pay with this "
"same physical card and you will automatically receive your new reduced fare. "
"You will need to reapply if you choose to change the bank card you use to "
"pay for transit service."

msgid "eligibility.pages.index.mst_cc.label"
msgstr "I have an MST Courtesy Card"

Expand Down
9 changes: 8 additions & 1 deletion benefits/locale/es/LC_MESSAGES/django.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
msgid ""
msgstr ""
"Report-Msgid-Bugs-To: https://github.com/cal-itp/benefits/issues \n"
"POT-Creation-Date: 2023-06-26 21:25+0000\n"
"POT-Creation-Date: 2023-06-28 22:08+0000\n"
"Language: Español\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
Expand Down Expand Up @@ -107,6 +107,13 @@ msgstr ""
"TODO: If you do not have an account with any of these services, you will "
"need to create one. We recommend using Login.gov."

msgid "enrollment.pages.success.veteran.confirm_item.details"
msgstr ""
"No se le ha cobrado nada hoy. Al abordar al el tránsito, pague con esta "
"misma tarjeta física y automáticamente recibirá su nueva tarifa reducida. "
"Deberá volver a presenter la solicitud si elige cambiar la tarjeta bancaria "
"que utiliza para pagar el servicio de transito."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this entry (enrollment.pages.success.veteran.confirm_item.details) is the same content as enrollment.pages.success.login_gov.confirm_item.details. We know that we'll be working on copy more next sprint, so this fix will do for the scope of this sprint.


msgid "eligibility.pages.index.mst_cc.label"
msgstr "Tengo una Tarjeta de Cortesía de MST"

Expand Down