Refactor: Enrollment index #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
i18n
thekaveman
force-pushed
the
refactor/enrollment-index
branch
from
1fb798f
to
c1a3c31
Compare
Closed
2 tasks
thekaveman
force-pushed
the
refactor/enrollment-index
branch
from
26f3da0
to
455683f
Compare
benefits/enrollment/templates/enrollment/includes/media_item__bankcardcheck__index.html
Outdated
Show resolved
Hide resolved
thekaveman
force-pushed
the
refactor/enrollment-index
branch
2 times, most recently
from
fb29378
to
eb7d759
Compare
|
🔥🔥🔥 |
thekaveman
force-pushed
the
refactor/enrollment-index
branch
2 times, most recently
from
6f1d5c0
to
6103572
Compare
|
This is not something I think we should change in this PR or any of the subsequent copy PRs, but I wanted to note this: The Media Item parent container width looks a bit too wide now. Not sure if this is a change in Figma, copy or what. It's something we can look into at the very very very end with @srhhnry once we finish everything else first -- after all the Modal links are in, I think. |
machikoyasuda
previously approved these changes
Jul 10, 2023
angela-tran
reviewed
Jul 10, 2023
thekaveman
force-pushed
the
refactor/enrollment-index
branch
from
6103572
to
0bf9292
Compare
otherwise variable is not available
|
Thanks for that find @angela-tran! I think it is because the variables aren't available outside of the In 3f8017e I moved the extra translate to within the button block. |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1479
Closes #1480 (copy)
Does not change how the sign out button works - this was getting a little more complicated and I didn't want to block this PR any longer. Plus that may depend on what happens in #1508.