Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update GitHub branch for sample eligibility server config #1862

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix: update GitHub branch for sample eligibility server config #1862

merged 1 commit into from
Jan 30, 2024

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Jan 30, 2024 •
edited

After cal-itp/eligibility-server#414 was merged and the dev branch was deleted over there, these URLs need to be updated to point to main.

Note these values are only used locally / in CI, not in production.

See e.g. failing Cypress tests, related to WIP PR #1859

@thekaveman thekaveman requested a review from a team as a code owner January 30, 2024 02:38
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev docker Application container, devcontainer, Compose, etc. migrations [auto] Review for potential model changes/needed data migrations updates back-end Django views, sessions, middleware, models, migrations etc. and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Jan 30, 2024
@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@thekaveman thekaveman added the bug Something isn't working label Jan 30, 2024
@thekaveman thekaveman self-assigned this Jan 30, 2024
@thekaveman thekaveman merged commit 06b17a9 into dev Jan 30, 2024
18 checks passed
@thekaveman thekaveman deleted the fix/eligibility-server-main branch January 30, 2024 16:52
@thekaveman thekaveman mentioned this pull request Jan 30, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. bug Something isn't working docker Application container, devcontainer, Compose, etc. migrations [auto] Review for potential model changes/needed data migrations updates
Projects
Digital Services
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thekaveman @machikoyasuda