Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: new default branch main #414

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Refactor: new default branch main #414

merged 7 commits into from
Jan 29, 2024

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Jan 26, 2024

Closes #290

See #290 for post-merge steps.

@thekaveman thekaveman requested a review from a team as a code owner January 26, 2024 01:26
@thekaveman thekaveman self-assigned this Jan 26, 2024
@thekaveman thekaveman linked an issue Jan 26, 2024 that may be closed by this pull request
9 tasks
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor suggestion for the workspace Python script. The rest of this looks good to me. Thank you so much @thekaveman !

terraform/pipeline/workspace.py Outdated Show resolved Hide resolved
terraform/pipeline/workspace.py Outdated Show resolved Hide resolved
terraform/pipeline/workspace.py Outdated Show resolved Hide resolved
@thekaveman
Copy link
Member Author

@machikoyasuda please review today if you are able.

Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and docs changes look good 👍

@thekaveman thekaveman merged commit 8f4d3ed into main Jan 29, 2024
7 checks passed
@thekaveman thekaveman deleted the refactor/main branch January 29, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully migrate to new deployment model
3 participants