-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy to test #94
Merged
Merged
Deploy to test #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return eligibility type instance directly
pulling from Docker Hub is becoming problematic, with sporadic and seemingly random timeouts and other issues instead take versioned copies of the image into a local ECR repository and point the config task container there remove Docker Hub secrets/config, add new ECR secrets/config
rather than managing new secrets and sed calls, use the aws-actions/aws-ecs-render-task-definition step and existing environment to fill the task template with config container image name
now that docs.calitp.org is served via a gh-pages org project we don't need a CNAME to get docs.calitp.org/benefits for free on this repo
* additional clarification of benefits application * reorganize Documentation section/subsections * add screenshot of quick edit pencil * links to directories and files
This reverts commit 6850de3
the load balancer is already hitting the healthcheck, and it is in charge or starting/restarting the ECS service anyway the container healthcheck is duplicative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws-cli
and remove container healthcheck