Refactor handling of eligibility types #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return eligibility type instance directly
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The central change in this PR is to adapt get/set of eligibility information from/to session to use the
EligibilityType.idproperty rather thanname. Since this object carries the value sent in the eligibility phase and also the group identifier for the enrollment phase, we may have multiple types with the same name pointing to different enrollment groups.The current logic relying on
namecauses errors when there are duplicates because we cannot determine whichEligibilityTypewas meant.A future todo could be to refactor the models to separate eligibility name and benefit group identifier.