Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: hero section #121

Merged
merged 9 commits into from
May 17, 2023
Merged

Refactor: hero section #121

merged 9 commits into from
May 17, 2023

Conversation

angela-tran
Copy link
Member

Closes #100

@angela-tran angela-tran added this to the Calitp.org redesign milestone May 16, 2023
@angela-tran angela-tran self-assigned this May 16, 2023
@angela-tran angela-tran requested a review from a team as a code owner May 16, 2023 22:34
@netlify
Copy link

netlify bot commented May 16, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit e24ae67
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/64650ba458023600070eaad4
😎 Deploy Preview https://deploy-preview-121--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@machikoyasuda
Copy link
Member

This is really nitpicky of me, but, just wanted to note here so we all know - these circles - or rather, oblong ovals, are not all the same sizes across the homepage.

image image image

The image in the app looked off to me, but actually, that's just the way the design is.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Desktop looks good

I see a few changes needed for mobile:

  • Spacing between the heading and paragraph should be 16px (currently 19px from the margin-bottom on h1)
  • Spacing between the paragraph and hero image should be 24px (currently 16px from the margin-bottom on the paragraph)
  • The bottom image changes for mobile to only be 3 dots with dashed line - maybe SVG is the way to go to handle screens of varying sizes?

@thekaveman
Copy link
Member

thekaveman commented May 16, 2023

Note: I realize the hero image "triforce" in Figma has zero whitespace at the top, but our image in the app has some padding around (in the actual image file). Maybe this is causing the difference in spacing. If it's easy to export a clean version from Figma that doesn't have whitespace around, try that? Otherwise maybe don't worry about that one.

@machikoyasuda
Copy link
Member

Oops - I didn't test mobile 😰

Another approach to the "transit stop line image thing goes from long to short on mobile" would be to show/hide the images based on a certain window width. It would be much easier to do this with the Bootstrap utility classes https://getbootstrap.com/docs/5.2/utilities/display/

Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment re: mobile/desktop image change

@machikoyasuda
Copy link
Member

@segacy1 Please re-export the triforce image with a tight crop, so that there's no extra white space on the edges (aside from the shadows), and send us the file (on Slack or GitHub).
image

@segacy1
Copy link

segacy1 commented May 17, 2023

Cropped up to the shadow:
triforce

@angela-tran
Copy link
Member Author

angela-tran commented May 17, 2023

@thekaveman @machikoyasuda I used Bootstrap's display utility classes to switch out the border image. I also used the new cropped "triforce" image that @segacy1 exported for us.

Based on what we talked about earlier, I am leaving spacing / margin / padding issues to be handled after we get our base grid fixed.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@angela-tran angela-tran merged commit d9974b7 into staging May 17, 2023
@angela-tran angela-tran deleted the refactor/hero-section branch May 17, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new Hero + border image on Homepage
4 participants