-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: hero section #121
Conversation
✅ Deploy Preview for cal-itp-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Desktop looks good
I see a few changes needed for mobile:
- Spacing between the heading and paragraph should be 16px (currently 19px from the margin-bottom on h1)
- Spacing between the paragraph and hero image should be 24px (currently 16px from the margin-bottom on the paragraph)
- The bottom image changes for mobile to only be 3 dots with dashed line - maybe SVG is the way to go to handle screens of varying sizes?
Note: I realize the hero image "triforce" in Figma has zero whitespace at the top, but our image in the app has some padding around (in the actual image file). Maybe this is causing the difference in spacing. If it's easy to export a clean version from Figma that doesn't have whitespace around, try that? Otherwise maybe don't worry about that one. |
Oops - I didn't test mobile 😰 Another approach to the "transit stop line image thing goes from long to short on mobile" would be to show/hide the images based on a certain window width. It would be much easier to do this with the Bootstrap utility classes https://getbootstrap.com/docs/5.2/utilities/display/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment re: mobile/desktop image change
@segacy1 Please re-export the triforce image with a tight crop, so that there's no extra white space on the edges (aside from the shadows), and send us the file (on Slack or GitHub). |
also removed unneeded media query style
change color for all headers that were using the old black color
styles are also applicable to a and li elements
9003b87
to
e24ae67
Compare
@thekaveman @machikoyasuda I used Bootstrap's Based on what we talked about earlier, I am leaving spacing / margin / padding issues to be handled after we get our base grid fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closes #100