Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): mobile nav link sizing is off, text now vertically centered #191

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

machikoyasuda
Copy link
Member

This was a bug I just noticed while testing the app on my phone.

  • Bug: On Mobile, the mobile nav links are not vertically centered. I think this was a CSS typo!

Screenshots: Staging vs. PR

image

@machikoyasuda machikoyasuda requested a review from a team as a code owner June 14, 2023 19:46
@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 84cacc2
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/648a19097e961400087a27a8
😎 Deploy Preview https://deploy-preview-191--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@machikoyasuda machikoyasuda self-assigned this Jun 14, 2023
@machikoyasuda machikoyasuda added this to the Calitp.org redesign milestone Jun 14, 2023
@machikoyasuda machikoyasuda merged commit b1d0d57 into staging Jun 14, 2023
@machikoyasuda machikoyasuda deleted the fix/nav-item-bug branch June 14, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants