Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: added new section for beginner analysts #1351

Merged
merged 17 commits into from
Apr 18, 2022
Merged

Conversation

amandaha8
Copy link
Contributor

@amandaha8 amandaha8 commented Apr 7, 2022

Overall Description

A new section will be added to the Docs, which contains tutorials for analysts who are new to Python.

Checklist for all PRs

  • Run pre-commit run --all-files to make sure markdown/lint passes

Docs changes checklist

  • [X ] If you haven't already, review the Contribute to the Docs section of the data services documentation for best practices, common formatting, and more
  • Make sure the preview website was able to be generated
  • Fill out the following section describing what docs were added/updated

This PR adds a new section called analytics_new_analysts in order to go over some of the pandas and geopandas skills analysts can expect to use.

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@amandaha8 amandaha8 marked this pull request as ready for review April 14, 2022 15:00
@github-actions
Copy link

@tiffanychu90
Copy link
Member

tiffanychu90 commented Apr 15, 2022

@amandaha8: Couple notes for docs:

  1. Check pages, 2 sets of next / previous arrows. I saw it on Data Analysis Intro / Intermediate, Data Analysis Intermediate, Spatial Analysis Basics / Intro / Intermediate / Advanced. Jupyterbook may have a way to add those navigation buttons already.
    2 Data Analysis Intro
  • GCS section: can you add a sentence + link to the page where we talk about credentials for GCS
  1. Data Management:
  • Some of the hyperlinks to jump down from the top bullet points don't work.
  • Misspellings: "numerous isses", "topolgical", "forumlas", "ie, Number" to be i.e. Number, "aggegrated queries"
  1. Geospatial Analysis: Basics
  • Use of my-geojson.parquet could be my-geoparquet.parquet or my-parquet.parquet to be more aligned with how other examples given
  • Capitalize EPSG for epsg:WGS84. Do this for all spatial pages.
  • Misspellings: "Califonia"
  1. Spatial Analysis Intro
  • Outdated syntax for spatial join appears a couple times: join = gpd.sjoin(locations, gdf, how = 'inner', op = 'intersects'). See geopandas docs.
  1. Spatial Analysis Intermediate
  • Use gpd.points_from_xy() instead of geopandas, since prior line is gpd. Also, update the syntax to be gdf.to_crs("EPSG:2965")

@github-actions
Copy link

@amandaha8 amandaha8 closed this Apr 15, 2022
@amandaha8 amandaha8 reopened this Apr 15, 2022
@github-actions
Copy link

@amandaha8
Copy link
Contributor Author

@tiffanychu90 I made all the changes except the link to GCS in data-management page. For some reason the link doesn't work, so I'll will ask you during our one on one.

@github-actions
Copy link

@tiffanychu90
Copy link
Member

@tiffanychu90 I made all the changes except the link to GCS in data-management page. For some reason the link doesn't work, so I'll will ask you during our one on one.

Took a quick look. You'll notice when you scroll and use the "table of contents" sidebar, the header is tagged with #gcs, but in the bullet points, it's #GCS. Fixing that should allow it to find the right hyperlink within the page.

@github-actions
Copy link

@amandaha8
Copy link
Contributor Author

@tiffanychu90 I made all the changes except the link to GCS in data-management page. For some reason the link doesn't work, so I'll will ask you during our one on one.

Took a quick look. You'll notice when you scroll and use the "table of contents" sidebar, the header is tagged with #gcs, but in the bullet points, it's #GCS. Fixing that should allow it to find the right hyperlink within the page.

My bad. It's fixed now!

@github-actions
Copy link

Copy link
Member

@charlie-costanzo charlie-costanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants