Added an option that allows users to specify the number of tries when… #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calling start_test_server_in_background. If the option is not specified it will default to 100. This fixes issue calabash#739
|
Can one of the admins verify this patch? |
| @@ -644,7 +644,8 @@ def start_test_server_in_background(options={}) | |||
| if keyguard_enabled? | |||
| wake_up | |||
| end | |||
|
|
|||
| app_tries = options[:app_launch_tries] || 100 | |||
| options.delete(:app_launch_tries) unless options[:app_launch_tries].nil? | |||
There was a problem hiding this comment.
We should not modify the given hash as it is a reference
There was a problem hiding this comment.
It should be something like, change env_options = options to env_options = options.dup, and remove the : app_launch_tries key using env_options.delete(:app_launch_tries), no need for an if.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… calling start_test_server_in_background. If the option is not specified it will default to 100. This fixes issue #739 and #800