Alert view support for iOS [redacted] #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And of course, I had overlooked the fact that calabash doesn't use ARC. added the proper autoreleases in the right place. |
krukow
added a commit
that referenced
this pull request
Aug 25, 2013
Alert view support for iOS [redacted]
|
Thanks @olarivain of OpenTable! I'll include this in the release notes. |
|
Thanks! Nice work |
|
Merged and released with 0.9.152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Karl,
After a few weeks of procrastination, it's finally here: support for tapping alert views in iOS whose version shalt not be named.
As usual, patches are WTF public license, just have an extra requirement this time: mention the patch was made by myself, on behalf of OpenTable (we're trying to get our name out in the iOS community :) )
Anyway, let me know if anything's wrong with the patch.