Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenshot route should use drawViewHierarchyInRect:afterScreenUpdates: for iOS 7 #347

Closed
6 of 7 tasks
jmoody opened this issue Apr 2, 2014 · 2 comments
Closed
6 of 7 tasks
Assignees
Milestone

Comments

@jmoody
Copy link
Member

jmoody commented Apr 2, 2014

motivation

Using drawViewHierarchyInRect:afterScreenUpdates will enable screenshotting of OpenGL views.

options

  1. Use drawViewHierarchyInRect:afterScreenUpdates and punt on the quality of the screenshots; the screenshots are good enough in my opinion.
  2. Detect UIAlertView or UIActionSheet in screenshot route and fall back to current behavior, otherwise use drawViewHierarchyInRect:afterScreenUpdates .
  3. Implement an OpenGL screenshot route that uses drawViewHierarchyInRect:afterScreenUpdates.

@Clancey - feel free to weigh in on this.

testing

_NB._ screenshots were taken after animations were completed.

  • OpenGL views - works great; there is no current solution
  • one-window view hierarchies - works the same as current solution
  • UIAlertView - not so good
  • UIActionSheet - as good as current solution
  • MFMailComposeViewController (email view controller) - works same as current solution
UIAlertView

uialertview-screenshot

UIActionSheet

The drawViewHierarchyInRect:afterScreenUpdates is arguably better than the current 0.9.168 screenshot.

uiactionsheet-screenshot

@jmoody
Copy link
Member Author

jmoody commented Sep 16, 2015

Moved to server.

@jmoody
Copy link
Member Author

jmoody commented Mar 1, 2016

Issues with UIAlertView and UIActionSheet have been resolved.

screenshot_2

screenshot_3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant