Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix run-loop to work with iOS 14 and Xcode 12 #757

Merged
merged 19 commits into from
Oct 30, 2020
Merged

Fix run-loop to work with iOS 14 and Xcode 12 #757

merged 19 commits into from
Oct 30, 2020

Conversation

AndreyMaslennikov
Copy link
Contributor

@AndreyMaslennikov AndreyMaslennikov commented Sep 11, 2020 •
edited
Loading

This PR contains:

  1. Fixes of localization
  2. Update for ADO CI to add Xcode 11.7 and 12 beta and remove older version in test matrix
  3. Skip tests for i386 simulators, because Xcode 12 beta is not supports 10.3.1 simulator runtime (it might be fixed in next beta versions. If so, we should revert this fix)

@svnm svnm mentioned this pull request Sep 23, 2020
Open
ivan-nosar
ivan-nosar reviewed Oct 13, 2020
View reviewed changes
Copy link

@ivan-nosar ivan-nosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI checks seem to be failed on the last commit. Please make sure about fixing it before making the merge
cc @AndreyMaslennikov @IlyaBausovAkvelon

@AndreyMaslennikov AndreyMaslennikov merged commit ff14fc6 into develop Oct 30, 2020
@IlyaBausovAkvelon IlyaBausovAkvelon deleted the v-andrem/ios-14-fixes branch September 2, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmoody jmoody jmoody left review comments

@ivan-nosar ivan-nosar ivan-nosar approved these changes

@IlyaBausovAkvelon IlyaBausovAkvelon IlyaBausovAkvelon approved these changes

@marsinchevskaya marsinchevskaya Awaiting requested review from marsinchevskaya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreyMaslennikov @jmoody @ivan-nosar @IlyaBausovAkvelon