Merge ccf094e into 0a34434

.rubocop.yml

@@ -0,0 +1,9 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  TargetRubyVersion: 2.2
+  Exclude:
+    - 'spec/dummy/**/*'
+
+Rails:
+  Enabled: true

.rubocop_todo.yml

@@ -0,0 +1,372 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2019-04-29 16:25:29 -0700 using RuboCop version 0.67.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
+# SupportedStylesAlignWith: start_of_line, def
+Layout/DefEndAlignment:
+  Exclude:
+    - 'app/controllers/calagator/venues_controller.rb'
+    - 'spec/support/time_zones.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
+# SupportedStylesAlignWith: keyword, variable, start_of_line
+Layout/EndAlignment:
+  Exclude:
+    - 'app/helpers/calagator/application_helper.rb'
+    - 'app/models/calagator/event.rb'
+    - 'app/models/calagator/event/browse.rb'
+    - 'app/models/calagator/event/search_engine/sql.rb'
+    - 'app/models/calagator/source/parser/hcal.rb'
+    - 'app/views/calagator/events/index.atom.builder'
+    - 'lib/calagator/duplicate_checking/duplicate_finder.rb'
+
+# Offense count: 4
+Lint/AmbiguousOperator:
+  Exclude:
+    - 'app/models/calagator/event/search_engine/apache_sunspot.rb'
+    - 'app/models/calagator/venue/search_engine/apache_sunspot.rb'
+    - 'lib/calagator/duplicate_checking.rb'
+    - 'lib/wait_for_solr.rb'
+
+# Offense count: 36
+Lint/AmbiguousRegexpLiteral:
+  Exclude:
+    - 'lib/calagator/vcalendar.rb'
+    - 'spec/controllers/calagator/events_controller_spec.rb'
+    - 'spec/controllers/calagator/sources_controller_spec.rb'
+    - 'spec/controllers/calagator/venues_controller_spec.rb'
+    - 'spec/models/calagator/event_spec.rb'
+
+# Offense count: 10
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Exclude:
+    - 'app/controllers/calagator/application_controller.rb'
+    - 'app/helpers/calagator/google_event_export_helper.rb'
+    - 'app/helpers/calagator/mapping_helper.rb'
+    - 'app/models/calagator/source/parser.rb'
+    - 'app/models/calagator/source/parser/facebook.rb'
+    - 'app/models/calagator/source/parser/hcal.rb'
+    - 'app/models/calagator/source/parser/meetup.rb'
+    - 'lib/calagator/machine_tag.rb'
+
+# Offense count: 1
+Lint/IneffectiveAccessModifier:
+  Exclude:
+    - 'app/controllers/calagator/application_controller.rb'
+
+# Offense count: 2
+Lint/RescueException:
+  Exclude:
+    - 'app/models/calagator/source/importer.rb'
+    - 'lib/calagator/vcalendar.rb'
+
+# Offense count: 4
+Lint/ShadowingOuterLocalVariable:
+  Exclude:
+    - 'app/models/calagator/event/search_engine/sql.rb'
+    - 'app/models/calagator/source/parser/hcal.rb'
+    - 'app/models/calagator/venue/search_engine/sql.rb'
+    - 'lib/calagator/duplicate_checking/duplicate_finder.rb'
+
+# Offense count: 1
+Lint/UriEscapeUnescape:
+  Exclude:
+    - 'app/helpers/calagator/events_helper.rb'
+
+# Offense count: 2
+# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
+Lint/UselessAccessModifier:
+  Exclude:
+    - 'app/models/calagator/event/search_engine.rb'
+    - 'app/models/calagator/venue/search_engine.rb'
+
+# Offense count: 47
+Lint/UselessAssignment:
+  Enabled: false
+
+# Offense count: 4
+# Configuration parameters: CheckForMethodsWithNoSideEffects.
+Lint/Void:
+  Exclude:
+    - 'spec/models/calagator/event/cloner_spec.rb'
+
+# Offense count: 29
+Metrics/AbcSize:
+  Max: 29
+
+# Offense count: 115
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 631
+
+# Offense count: 1
+Metrics/CyclomaticComplexity:
+  Max: 7
+
+# Offense count: 20
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 21
+
+# Offense count: 12
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 633
+
+# Offense count: 2
+Naming/AccessorMethodName:
+  Exclude:
+    - 'app/helpers/calagator/time_range_helper.rb'
+    - 'app/models/calagator/source/parser/meetup.rb'
+
+# Offense count: 1
+# Configuration parameters: Blacklist.
+# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+Naming/HeredocDelimiterNaming:
+  Exclude:
+    - 'bin/calagator'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyleForLeadingUnderscores.
+# SupportedStylesForLeadingUnderscores: disallowed, required, optional
+Naming/MemoizedInstanceVariableName:
+  Exclude:
+    - 'app/controllers/calagator/application_controller.rb'
+
+# Offense count: 2
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+# MethodDefinitionMacros: define_method, define_singleton_method
+Naming/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'app/models/calagator/event/saver.rb'
+    - 'lib/calagator/duplicate_checking/duplicate_finder.rb'
+
+# Offense count: 3
+# Configuration parameters: PreferredName.
+Naming/RescuedExceptionsVariableName:
+  Exclude:
+    - 'app/controllers/calagator/sources_controller.rb'
+    - 'app/controllers/calagator/venues_controller.rb'
+    - 'lib/calagator/vcalendar.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/RedundantMatch:
+  Exclude:
+    - 'app/controllers/calagator/site_controller.rb'
+
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: db/migrate/*.rb
+Rails/CreateTableWithTimestamps:
+  Exclude:
+    - 'db/migrate/20080705164959_create_tags_and_taggings.rb'
+
+# Offense count: 11
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: strict, flexible
+Rails/Date:
+  Exclude:
+    - 'app/models/calagator/event.rb'
+    - 'app/models/calagator/event/cloner.rb'
+    - 'app/models/calagator/event/search_engine/apache_sunspot.rb'
+    - 'app/models/calagator/event/search_engine/sql.rb'
+    - 'lib/calagator/vcalendar.rb'
+    - 'spec/models/calagator/event/cloner_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: slashes, arguments
+Rails/FilePath:
+  Exclude:
+    - 'spec/lib/calagator/blacklist_validator_spec.rb'
+    - 'spec/rails_helper.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/InverseOf:
+  Exclude:
+    - 'app/models/calagator/venue.rb'
+
+# Offense count: 3
+# Configuration parameters: Include.
+# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
+Rails/Output:
+  Exclude:
+    - 'db/seeds.rb'
+
+# Offense count: 8
+Rails/OutputSafety:
+  Exclude:
+    - 'app/helpers/calagator/application_helper.rb'
+    - 'app/helpers/calagator/tags_helper.rb'
+    - 'app/helpers/calagator/time_range_helper.rb'
+
+# Offense count: 2
+Rails/ReflectionClassName:
+  Exclude:
+    - 'lib/calagator/duplicate_checking.rb'
+
+# Offense count: 6
+# Configuration parameters: Blacklist, Whitelist.
+# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
+Rails/SkipsModelValidations:
+  Exclude:
+    - 'app/models/calagator/event.rb'
+    - 'app/models/calagator/venue.rb'
+    - 'lib/calagator/duplicate_checking/duplicate_squasher.rb'
+    - 'spec/models/calagator/event_spec.rb'
+
+# Offense count: 1
+Security/Eval:
+  Exclude:
+    - 'Vagrantfile'
+
+# Offense count: 5
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: inline, group
+Style/AccessModifierDeclarations:
+  Exclude:
+    - 'app/controllers/calagator/sources_controller.rb'
+    - 'app/controllers/calagator/venues_controller.rb'
+    - 'app/helpers/calagator/events_helper.rb'
+    - 'app/models/calagator/event.rb'
+
+# Offense count: 1
+Style/CaseEquality:
+  Exclude:
+    - 'app/models/calagator/source/parser/facebook.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'app/models/calagator/source/parser.rb'
+    - 'app/models/calagator/source/parser/facebook.rb'
+    - 'app/models/calagator/source/parser/hcal.rb'
+    - 'app/models/calagator/source/parser/http_authentication_required_error.rb'
+    - 'app/models/calagator/source/parser/ical.rb'
+    - 'app/models/calagator/source/parser/meetup.rb'
+    - 'app/models/calagator/source/parser/not_found.rb'
+    - 'spec/dummy/test/test_helper.rb'
+    - 'spec/support/assert_dom_equal.rb'
+
+# Offense count: 103
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 11
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'app/controllers/calagator/events_controller.rb'
+    - 'app/helpers/calagator/events_helper.rb'
+    - 'app/helpers/calagator/time_range_helper.rb'
+    - 'app/models/calagator/event/saver.rb'
+    - 'app/models/calagator/event/search.rb'
+    - 'db/migrate/20150407014754_change_collation_for_tag_names.acts_as_taggable_on_engine.rb'
+    - 'lib/active_model/sequential_validator.rb'
+    - 'lib/calagator/blacklist_validator.rb'
+    - 'lib/generators/calagator/install_generator.rb'
+    - 'spec/dummy/db/migrate/20190419234221_change_collation_for_tag_names.acts_as_taggable_on_engine.rb'
+
+# Offense count: 15
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'app/helpers/calagator/application_helper.rb'
+    - 'app/helpers/calagator/events_helper.rb'
+    - 'app/models/calagator/event/cloner.rb'
+    - 'app/models/calagator/event/saver.rb'
+    - 'app/models/calagator/event/search.rb'
+    - 'app/views/calagator/events/index.atom.builder'
+    - 'db/migrate/20120709092821_cleanup.rb'
+    - 'db/migrate/20150407014754_change_collation_for_tag_names.acts_as_taggable_on_engine.rb'
+    - 'lib/active_model/sequential_validator.rb'
+    - 'lib/calagator/blacklist_validator.rb'
+    - 'lib/calagator/decode_html_entities_hack.rb'
+    - 'lib/calagator/duplicate_checking/duplicate_squasher.rb'
+    - 'lib/calagator/strip_whitespace.rb'
+    - 'spec/dummy/db/migrate/20190419234221_change_collation_for_tag_names.acts_as_taggable_on_engine.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/LineEndConcatenation:
+  Exclude:
+    - 'config/initializers/formtastic.rb'
+
+# Offense count: 1
+Style/MissingRespondToMissing:
+  Exclude:
+    - 'lib/calagator/vcalendar.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, Autocorrect.
+# SupportedStyles: module_function, extend_self
+Style/ModuleFunction:
+  Exclude:
+    - 'app/helpers/calagator/time_range_helper.rb'
+
+# Offense count: 1
+Style/MultilineBlockChain:
+  Exclude:
+    - 'app/models/calagator/source/parser/hcal.rb'
+
+# Offense count: 1
+Style/MultilineTernaryOperator:
+  Exclude:
+    - 'app/helpers/calagator/events_helper.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'app/helpers/calagator/time_range_helper.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: .
+# SupportedStyles: use_perl_names, use_english_names
+Style/SpecialGlobalVars:
+  EnforcedStyle: use_perl_names
+
+# Offense count: 28
+Style/StructInheritance:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+# IgnoredMethods: respond_to, define_method
+Style/SymbolProc:
+  Exclude:
+    - 'app/models/calagator/event/search_engine/apache_sunspot.rb'
+    - 'app/models/calagator/source/parser/ical.rb'
+
+# Offense count: 611
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 278