Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagIcon#exists? will not work in production #524

Closed
reidab opened this issue Mar 29, 2017 · 0 comments · Fixed by #586
Closed

TagIcon#exists? will not work in production #524

reidab opened this issue Mar 29, 2017 · 0 comments · Fixed by #586
Assignees
@aeschright
Labels
bug
Projects
Calagator maintenance

Comments

@reidab
Copy link
Member

reidab commented Mar 29, 2017

The code in TagHelper::TagIcon#exists? attempts to search Rails.application.assets, which will be nil in the production environment.
@aeschright aeschright added this to Needs triage in Calagator maintenance Sep 28, 2018
@aeschright aeschright added the bug label Oct 20, 2018
@aeschright aeschright self-assigned this Apr 30, 2019
aeschright added a commit that referenced this issue May 1, 2019
@aeschright
Fix tag icons to work with precompiled assets in production
cbb34fc 
Closes #524
@aeschright aeschright mentioned this issue May 1, 2019
Merged
aeschright added a commit that referenced this issue May 1, 2019
@aeschright
Use appropriate check for tag icon assets depending on environment pr…
c7c00a6 
…ecompile setting

Fixes #524
@aeschright aeschright added this to Backlog in 1.X Roadmap May 1, 2019
@aeschright aeschright moved this from Backlog to To do in 1.X Roadmap May 1, 2019
@aeschright aeschright removed this from To do in 1.X Roadmap May 1, 2019
@aeschright aeschright moved this from Needs triage to Verified in Calagator maintenance May 1, 2019
Calagator maintenance automation moved this from Verified to Closed May 3, 2019
aeschright added a commit that referenced this issue May 3, 2019
@aeschright
Fix tag icons (#586)
d5ff304 
* deps: add uglifier for testing asset precompile
* Use appropriate check for tag icon assets depending on environment precompile setting
Fixes #524
* Deprecate support for Rails pre-4.2 and add newer Ruby versions to CI
* Drop support for Ruby 2.2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeschright aeschright

Labels
bug
Projects
Calagator maintenance
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tag icons calagator/calagator
2 participants
@reidab @aeschright