Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect dead links back to calagator root #145 #149

Closed
wants to merge 1 commit into from
Closed

redirect dead links back to calagator root #145 #149

wants to merge 1 commit into from

Conversation

supremebeing7
Copy link
Contributor

Unsure of where these should ultimately be redirected.

@reidab
Copy link
Member

reidab commented Jul 27, 2014

There's a test for the link generation helper in spec/models/tag_spec.rb that uses an Upcoming URL as an example and needs to be updated.

That said, I'm not sure if linking back to Calagator's root is the optimal behavior for these sites that have been shut down. I think we should either remove the linking behavior for these services, letting the tags act like normal Calagator tags, or adopt Audrey's suggestion from yesterday to present a page telling people that the service has shuttered and offering them a link to archive.org version of the URL.

@supremebeing7
Copy link
Contributor Author

I liked Audrey's suggestion, I heard it after doing this commit. I can probably fix this up, but I'm not super familiar with Archive.org. Are we talking about just offering a link to the whole URL history on archive.org? i.e. https://web.archive.org/web/*/http://upcoming.yahoo.com/event/1234 ?
This would be pretty simple.

Or should we link to the last working version of that URL on archive.org? Because that's probably something the Wayback Machine API could do, I just don't know how without some additional time expenditure.

@reidab
Copy link
Member

reidab commented Jul 28, 2014

From looking at the docs at http://en.wikipedia.org/wiki/Help:Using_the_Wayback_Machine#Specific_archive_copy and towards the bottom of http://archive.org/web/web-advancedsearch.php, it looks like the date provided in the archive.org URL doesn't have to be an exact match for the version and can be truncated.

So, for this event, we can generate an archive.org link based on date of the event, which will redirect to the closest known version to that date, like so: https://web.archive.org/web/20100914/http://upcoming.yahoo.com/event/6568739

In the case of Upcoming, this isn't much to look at, but other services may fare better. For venue tags, I suggest using the creation date of the venue for the archive date.

@supremebeing7
Copy link
Contributor Author

Made a new pull request #159 per these discussions. Closing this one.

@supremebeing7 supremebeing7 deleted the fix_dead_tags_145 branch July 28, 2014 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants