Remove various TODOs #151
Merged
Remove various TODOs #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 26, 2014 15:54
(also removed some unused variable names)
If it hasn't come up then it's YAGNI. If it does come up, there won't be any need for a TODO comment to tell you it's not working :)
I don't know if we want to keep providing this. Why wouldn't we, though?
abstract_location indeed can't be blank. This code is only called if it's at least truthy; see models/event.rb. (Also removed some commented-out code that created a false positive in my grepping...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more, but this is what I had time to grab. Implemented some, created issues for others, and just deleted a couple outright.