Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of add/edit event form required fields #598

Merged
merged 2 commits into from Mar 28, 2020

Conversation

carrythebanner
Copy link

On the add/edit event form:

  • Required input fields now use the required attribute.
  • The asterisk in the required field's label is now a visual only cue (it will be skipped by screen readers).
  • The visible "@" and "to" labels for the date and time fields are skipped by screen readers, and more explicit, non-visible labels have been added for screen readers.

For more background on these, see:

@aeschright
Copy link
Member

Thanks @carrythebanner -- this looks great! Can you fix up the merge conflict so we can pull this in?

@reidab reidab force-pushed the event-form-required-fields branch 3 times, most recently from 5c13e04 to 81c1daa Compare March 28, 2020 23:07
@reidab reidab force-pushed the event-form-required-fields branch from 81c1daa to 9ba588d Compare March 28, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants