Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTALL to mention mounting the engine and running migrations #697

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nickhammond
Copy link

No description provided.

@reidab
Copy link
Member

reidab commented May 20, 2022

This should be being handled by the calagator:install generator as part of the previous generation steps here:

https://github.com/calagator/calagator/blob/main/lib/generators/calagator/install_generator.rb#L26-L28

That said, I know there were some issues with the app template and the recent rails upgrade work, so it's possible the generator isn't being run correctly. If it's not, I wonder if it makes more sense to add a manual run of rails generate calagator:install to the README instead of adding the route manually?

@nickhammond
Copy link
Author

Running that is throwing an error so that might've been why it didn't run and add it.

Rails 5.2.7.1

➜  events git:(main) ✗ bundle exec calagator install
rake aborted!
Don't know how to build task 'rails:template' (See the list of available tasks with `rake --tasks`)
/Users/nick/.gem/ruby/2.5.9/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/lib/bundler/cli/exec.rb:58:in `load'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/lib/bundler/cli/exec.rb:58:in `kernel_load'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/lib/bundler/cli/exec.rb:23:in `run'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/lib/bundler/cli.rb:483:in `exec'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/lib/bundler/cli.rb:31:in `dispatch'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/lib/bundler/cli.rb:25:in `start'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/exe/bundle:48:in `block in <top (required)>'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/lib/bundler/friendly_errors.rb:103:in `with_friendly_errors'
/Users/nick/.gem/ruby/2.5.9/gems/bundler-2.3.13/exe/bundle:36:in `<top (required)>'
/Users/nick/.gem/ruby/2.5.9/bin/bundle:23:in `load'
/Users/nick/.gem/ruby/2.5.9/bin/bundle:23:in `<main>'
(See full trace by running task with --trace)

@evolve2k
Copy link

Anyone have suggestions on what next for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants