New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure with Qt 5.4.0 beta #125
Comments
Confirmed here, I waited to report, but fails here both with Qt 5.4 alpha and beta. |
A readable version of the error messages:
|
Do you think this is a Qt bug? If so, we need to report it to Qt ASAP. |
No, this is my doing. It probably popped up because in your build "cc1plus: some warnings being treated as errors". Good catch. I'm triggering an ambiguous override for QList::operator= and a C++11-style init list. Will fix. |
@kkofler Please check if it builds now. |
Attempt to fix calamares#125
Still fails here, as shown, Qt 5.4 beta in use: ==> Retrieving sources...
-- Found Calamares module: displaymanager -- Found Calamares module: grub -- Found Calamares module: dracut -- Found Calamares module: services -- Found Calamares module: nonfree_drivers -- Found KF5Config: /usr/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.3.0") -- Found Calamares module: initcpiocfg -- Found Calamares module: unpackfs -- Found Calamares module: umount -- Found Calamares module: bootloader -- Found Calamares module: dummyprocess -- Found Calamares module: usercfg -- Found Calamares module: initcpio -- Found Calamares module: locale -- Found Calamares module: greeting -- Found Calamares module: summary -- Found Calamares module: hwclock -- Found Calamares module: grubcfg -- Found Calamares module: fstab -- Found Calamares module: dummypython -- Found Calamares module: localegen -- Found Calamares module: driver_cleanup -- Found Calamares module: keyboard -- Found Calamares module: package_removal -- Found Calamares module: packages -- Found Calamares module: networkcfg -- Found Crypt: /usr/lib/libcrypt.so -- Found Calamares module: prepare -- Found Calamares branding component: default -- Found Calamares branding component: kaos_branding -- The following external packages were located on your system. -- This installation will have the extra features provided by these packages.
-- Congratulations! All external packages have been found.-- Configuring done Packages (135): aalib-1.4rc5-8 cairo-1.14.0-1 cdparanoia-10.2-3 celt-0.11.3-2 chromaprint-1.1-2 compositeproto-0.4.2-2 dbus-c++-0.9.0-3 dbus-glib-0.102-1 Total Removed Size: 441.63 MiB :: Do you want to remove these packages? [Y/n] |
The reason I'm asking whether this is a Qt bug is that the same code is building fine with 5.3.2 and failing to build with 5.4.0 beta. It looks like an ambiguity was introduced in 5.4. |
This Qt change is causing the ambiguity: |
I think the lines should probably read: return chrootCall( (QStringList) { command }, |
Or maybe QStringList({command}) or just QStringList {command}, as per: |
Or of course you could go all boring old-school C++98 ;-) and just write QStringList() << command instead, as we've been doing all this time. |
Pushed another change, please give it a spin. |
Still fails here (Qt 5.4 beta only, no issue on Qt 5.3.2): [ 35%] Building CXX object src/libcalamaresui/CMakeFiles/calamaresui.dir/modulesystem/ModuleManager.cpp.o |
Same error, different file. This needs the same fix (s/QStringList() = /QStringList/). |
Issue fixed here with commit 10ca853 |
Also works for me on Fedora Rawhide: |
Calamares fails to build for me on Fedora Rawhide, where we have Qt 5.4.0 beta. (It builds fine on Fedora 21.)
This is the output, blame issue #124 for its unreadability:
The text was updated successfully, but these errors were encountered: