Calamares 3.3 - Welcome page does not load image

[abalfoort]

Describe the bug
Open Calamares 3.3 welcome module does not show image anymore.

To Reproduce
Steps to reproduce the behavior:

1. Start Calamares 3.3 with the default settings.conf (no other changes made).
2. Welcome page loads languages but not the image

Expected behavior
Show the configured image in the welcome module.

Screenshots and Logs

I found this in the log:

2022-06-04 - 13:51:01 [2]: void Calamares::QmlViewStep::showFailedQml()
    WARNING: QmlViewStep "welcomeq@welcomeq" loading failed. 
2022-06-04 - 13:51:01 [6]:     .. QML error: "qrc:/welcomeq.qml:17 module \"QtGraphicalEffects\" is not installed\nqrc:/welcomeq.qml:16 module \"org.kde.kirigami\" is not installed\nqrc:/welcomeq.qml:15 module \"QtQuick.Layouts\" is not installed\nqrc:/welcomeq.qml:14 module \"QtQuick.Controls\" is not installed\nqrc:/welcomeq.qml:17 module \"QtGraphicalEffects\" is not installed\nqrc:/welcomeq.qml:16 module \"org.kde.kirigami\" is not installed\nqrc:/welcomeq.qml:15 module \"QtQuick.Layouts\" is not installed\nqrc:/welcomeq.qml:14 module \"QtQuick.Controls\" is not installed\nqrc:/welcomeq.qml:17 module \"QtGraphicalEffects\" is not installed\nqrc:/welcomeq.qml:16 module \"org.kde.kirigami\" is not installed\nqrc:/welcomeq.qml:15 module \"QtQuick.Layouts\" is not installed\nqrc:/welcomeq.qml:14 module \"QtQuick.Controls\" is not installed\nqrc:/welcomeq.qml:17 module \"QtGraphicalEffects\" is not installed\nqrc:/welcomeq.qml:16 module \"org.kde.kirigami\" is not installed\nqrc:/welcomeq.qml:15 module \"QtQuick.Layouts\" is not installed\nqrc:/welcomeq.qml:14 module \"QtQuick.Controls\" is not installed\n" 

After installing qml-module-org-kde-kirigami2 (pulls in qml-module-qtgraphicaleffects, qml-module-qtquick-layouts, qml-module-qtquick-controls) the above mentioned warning was gone, but the welcome module still did not load the image.

Log after apt install:
session.log

[demmm]

Welcomeq does not have the loading issue, Welcome has the same for me and one other distribution, so not related to the incomplete dependency you see. Just build Calamares and include welcomeq to the list of excluded modules -DSKIP_MODULES="welcomeq", if you don't want to see that error.

[abalfoort]

I can confirm that welcomeq does function provided that the qml-module-org-kde-kirigami2 package and its dependencies are installed.

I am still unable to find the cause of this bug in the welcome module.

[adriaandegroot]

The welcome module has a bit of a tangle, yeah:

• the Page has a CheckerContainer, which can hold either:
  • a waiting widget, showing the big spinner during the first round that the requirements are checked,
  • a ResultsListWidget, showing the results of the check
• the ResultsListWidget can hold either:
  • the "success" image, which should be shown when there are no issues
  • a list of issues, along with an indication that the issues are going to be re-checked

There was a missing call to update the display of the requirements in the ResultsListWidget, The ModuleManager is the one emitting signals to coordinate all this, but it does not have detailed signals (e.g. intend-to-recheck, will-not-recheck-anymore) that could be hooked up to the widgets displaying that information.

[abalfoort]

I see, thanks for the explanation.