Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial additional layout support for non-ASCII layouts #1553

Merged
merged 11 commits into from Oct 27, 2020

Conversation

LordTermor
Copy link
Contributor

No description provided.

@adriaandegroot adriaandegroot merged commit dca9ae0 into calamares:calamares Oct 27, 2020
@adriaandegroot
Copy link
Contributor

Merged, thank you! I have a fix-keyboardq branch that uses all the new Config bits -- it is actually more about fixing the keyboard module, and I can tell that the right files are written with improved layouts already -- which will land shortly and bring in your work for the next release.

Looking at the code afterwards for style and improvements, I was wondering about this one:

 static AdditionalLayoutInfo getAdditionalLayoutInfo( const QString& layout );

That looks like it could be a constructor of AdditionalLayoutInfo (although then it would also need a default constructor, I think) and then the documentation for what that represents can move to the AdditionalLayoutInfo header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants