#1818 tmpfs on tmp

[abalfoort]

This fixes #1818

Configure mounting /tmp as tmpfs in fstab can be configured in fstab.conf.
Old behavior (mounting /tmp as tmpfs) is still default if not configured differently in fstab.conf.

[adriaandegroot]

Please squash these PR's into something that follows the regular coding style and commit style. You can use git rebase -i to go through the commits to tidy them up.

[adriaandegroot]

The code is good, and I appreciate your attention to getting defaults and not crashing on missing configuration keys (something other Python modules do a lot). Also updating the schema, thanks.

[abalfoort]

Could you eleborate on: "squash these PR's"?
I don't know how to tidy up the PRs (using git rebase -i).

[adriaandegroot]

To tidy this up, I started by following the manual instructions for merging this branch. That leads to a situation that looks like this (in qgit, my preferred git-history-viewer; it looks slightly different in gitk).

The red nodes are your branch, which are mostly not needed: the "Configure.." and "Remove print.." commits are the useful ones. So I run git rebase -i calamares to re-do the branch on top of the calamares branch. This puts me in an editor where I can interactively edit the history:

I can replace the word pick there by a letter -- documentation is shown in the edit window -- to change the history. I delete the first two lines, since those are merges / noise. Then "Fix unencrypted.." gets an r because I want to edit the commit message slightly, and the last one gets an s to squash it with the previous commit (and I'll edit the commit message).

When squashing, you get all the commit messages together, and then you can edit all you like:

[abalfoort]

Just a recap to see if I get it now:

1. Rebase with calamares: git rebase -i calamares.
2. Look for first commit you want to keep and label it "r".
3. Remove commits above that one.
4. The commit below the "r" labeled one does not change and keeps label "pick".
5. Anything below that is squased by labelling them with "s".

Correct?

[kkofler]

For what it's worth, on Fedora, /tmp is on tmpfs by default without any /etc/fstab entry, they decided to set this up with a native systemd unit instead.