Skip to content

fix: conditionally remove fixed prop if we're in embed #20976

fix: conditionally remove fixed prop if we're in embed

fix: conditionally remove fixed prop if we're in embed #20976

Triggered via pull request April 15, 2024 11:32
@sean-brydonsean-brydon
synchronize #14586
Status Success
Total duration 18m 51s
Artifacts 13

pr.yml

on: pull_request_target
Detect changes
15s
Detect changes
Analyze Build  /  ...  /  Build
Analyze Build / Production build / Build
Matrix: E2E App Store tests / e2e-app-store
Matrix: E2E React embeds tests / e2e-embed
Matrix: E2E embeds tests / e2e-embed
Matrix: E2E tests / e2e
Analyze Build  /  analyze
2m 5s
Analyze Build / analyze
required
4s
required
Fit to window
Zoom out
Zoom in

Annotations

18 errors, 20 warnings, and 10 notices
[@calcom/embed-core] › packages/embeds/embed-core/playwright/tests/inline.e2e.ts:8:7 › Inline Iframe › Inline Iframe - Configured with Dark Theme: packages/embeds/embed-core/playwright/tests/inline.e2e.ts#L25
1) [@***com/embed-core] › packages/embeds/embed-core/playwright/tests/inline.e2e.ts:8:7 › Inline Iframe › Inline Iframe - Configured with Dark Theme Error: Embed iframe not found 23 | // expect(await page.screenshot()).toMatchSnapshot("event-types-list.png"); 24 | if (!embedIframe) { > 25 | throw new Error("Embed iframe not found"); | ^ 26 | } 27 | await bookFirstEvent("pro", embedIframe, page); 28 | await deleteAllBookingsByEmail("embed-user@example.com"); at /home/runner/actions-runner/_work/***.com/***.com/packages/embeds/embed-core/playwright/tests/inline.e2e.ts:25:13
[@calcom/embed-core] › packages/embeds/embed-core/playwright/tests/inline.e2e.ts:8:7 › Inline Iframe › Inline Iframe - Configured with Dark Theme: packages/embeds/embed-core/playwright/tests/inline.e2e.ts#L1
1) [@***com/embed-core] › packages/embeds/embed-core/playwright/tests/inline.e2e.ts:8:7 › Inline Iframe › Inline Iframe - Configured with Dark Theme Test timeout of 60000ms exceeded while tearing down "context".
[@calcom/app-store] › packages/app-store/routing-forms/playwright/tests/basic.e2e.ts:325:9 › Routing Forms › Seeded Routing Form › Routing Link should validate fields: packages/app-store/routing-forms/playwright/tests/basic.e2e.ts#L329
1) [@***com/app-store] › packages/app-store/routing-forms/playwright/tests/basic.e2e.ts:325:9 › Routing Forms › Seeded Routing Form › Routing Link should validate fields page.click: Target closed =========================== logs =========================== waiting for locator('button[type="submit"]') locator resolved to <button type="submit" class="whitespace-nowrap inline-fl…>Submit</button> attempting click action waiting for element to be visible, enabled and stable element is visible, enabled and stable scrolling into view if needed done scrolling performing click action ============================================================ 327 | const routingForm = user.routingForms[0]; 328 | await gotoRoutingLink({ page, formId: routingForm.id }); > 329 | page.click('button[type="submit"]'); | ^ 330 | const firstInputMissingValue = await page.evaluate(() => { 331 | return document.querySelectorAll("input")[0].validity.valueMissing; 332 | }); at /home/runner/actions-runner/_work/***.com/***.com/packages/app-store/routing-forms/playwright/tests/basic.e2e.ts:329:12
[@calcom/app-store] › packages/app-store/routing-forms/playwright/tests/basic.e2e.ts:325:9 › Routing Forms › Seeded Routing Form › Routing Link should validate fields: packages/app-store/routing-forms/playwright/tests/basic.e2e.ts#L1
1) [@***com/app-store] › packages/app-store/routing-forms/playwright/tests/basic.e2e.ts:325:9 › Routing Forms › Seeded Routing Form › Routing Link should validate fields Test timeout of 60000ms exceeded while tearing down "context".
[@calcom/web] › apps/web/playwright/organization/organization-invitation.e2e.ts:94:9 › Organization › Email not matching orgAutoAcceptEmail › nonexisting user invited to a Team inside organization: apps/web/playwright/organization/organization-invitation.e2e.ts#L1
1) [@***com/web] › apps/web/playwright/organization/organization-invitation.e2e.ts:94:9 › Organization › Email not matching orgAutoAcceptEmail › nonexisting user invited to a Team inside organization Test timeout of 60000ms exceeded.
[@calcom/web] › apps/web/playwright/organization/organization-invitation.e2e.ts:94:9 › Organization › Email not matching orgAutoAcceptEmail › nonexisting user invited to a Team inside organization: apps/web/playwright/lib/testUtils.ts#L213
1) [@***com/web] › apps/web/playwright/organization/organization-invitation.e2e.ts:94:9 › Organization › Email not matching orgAutoAcceptEmail › nonexisting user invited to a Team inside organization page.waitForResponse: Page closed =========================== logs =========================== waiting for response "**/api/trpc/teams/createInvite?batch=1" ============================================================ at apps/web/playwright/lib/testUtils.ts:213 211 | 212 | export async function getInviteLink(page: Page) { > 213 | const response = await page.waitForResponse("**/api/trpc/teams/createInvite?batch=1"); | ^ 214 | const json = await response.json(); 215 | return json[0].result.data.json.inviteLink as string; 216 | } at getInviteLink (/home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/lib/testUtils.ts:213:31) at copyInviteLink (/home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/organization/organization-invitation.e2e.ts:557:41) at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/organization/organization-invitation.e2e.ts:170:28 at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/organization/organization-invitation.e2e.ts:168:7
[@calcom/web] › apps/web/playwright/profile.e2e.ts:375:7 › Update Profile › Can resend verification link if the secondary email is unverified: apps/web/playwright/profile.e2e.ts#L212
2) [@***com/web] › apps/web/playwright/profile.e2e.ts:375:7 › Update Profile › Can resend verification link if the secondary email is unverified Error: expect(received).toEqual(expected) // deep equality Expected: "http://***:3000/api/auth/verify-email?token=undefined" Received: "http://***:3000/api/auth/verify-email?token=9d74cda08fc84f7a40439c408a654b3d5a6c92348e1cab69ec7ffedec0c55f56" 210 | "verify-email" 211 | ); > 212 | expect(inviteLink).toEqual(`${WEBAPP_URL}/api/auth/verify-email?token=${verificationToken?.token}`); | ^ 213 | }); 214 | }; 215 | at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/profile.e2e.ts:212:26 at testEmailVerificationLink (/home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/profile.e2e.ts:198:5) at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/profile.e2e.ts:398:5
[@calcom/web] › apps/web/playwright/login.e2e.ts:16:7 › user can login & logout succesfully -- future › login flow user & logout using dashboard: apps/web/playwright/login.e2e.ts#L40
1) [@***com/web] › apps/web/playwright/login.e2e.ts:16:7 › user can login & logout succesfully -- future › login flow user & logout using dashboard Error: Timed out 30000ms waiting for expect(received).toBeVisible() Call log: - expect.toBeVisible with timeout 30000ms - waiting for locator('[data-testid=login-form]') - waiting for locator('[data-testid=login-form]') 38 | 39 | // Reroute to the home page to check if the login form shows up > 40 | await expect(page.locator(`[data-testid=login-form]`)).toBeVisible(); | ^ 41 | }); 42 | }); 43 | }); at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/login.e2e.ts:40:62 at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/login.e2e.ts:28:5
[@calcom/web] › apps/web/playwright/event-types.e2e.ts:250:11 › Event Types tests -- legacy › user › Different Locations Tests › Can remove location from multiple locations that are saved: apps/web/playwright/event-types.e2e.ts#L1
1) [@***com/web] › apps/web/playwright/event-types.e2e.ts:250:11 › Event Types tests -- legacy › user › Different Locations Tests › Can remove location from multiple locations that are saved Test timeout of 60000ms exceeded.
[@calcom/web] › apps/web/playwright/event-types.e2e.ts:250:11 › Event Types tests -- legacy › user › Different Locations Tests › Can remove location from multiple locations that are saved: apps/web/playwright/event-types.e2e.ts#L378
1) [@***com/web] › apps/web/playwright/event-types.e2e.ts:250:11 › Event Types tests -- legacy › user › Different Locations Tests › Can remove location from multiple locations that are saved locator.click: Target closed =========================== logs =========================== waiting for locator('[data-testid=update-eventtype]') locator resolved to <button disabled type="submit" form="event-type-form" da…>…</button> attempting click action waiting for element to be visible, enabled and stable element is not enabled - waiting... ============================================================ 376 | 377 | async function saveEventType(page: Page) { > 378 | await page.locator("[data-testid=update-eventtype]").click(); | ^ 379 | } 380 | 381 | async function gotoBookingPage(page: Page) { at saveEventType (/home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/event-types.e2e.ts:378:56) at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/event-types.e2e.ts:266:15
[@calcom/web] › apps/web/playwright/event-types.e2e.ts:250:11 › Event Types tests -- legacy › user › Different Locations Tests › Can remove location from multiple locations that are saved: apps/web/playwright/event-types.e2e.ts#L1
1) [@***com/web] › apps/web/playwright/event-types.e2e.ts:250:11 › Event Types tests -- legacy › user › Different Locations Tests › Can remove location from multiple locations that are saved Pending operations: - locator.click at apps/web/playwright/event-types.e2e.ts:378:56
[@calcom/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members: apps/web/playwright/teams.e2e.ts#L1
1) [@***com/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members Test timeout of 60000ms exceeded.
[@calcom/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members: apps/web/playwright/teams.e2e.ts#L51
1) [@***com/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members locator.click: Target closed =========================== logs =========================== waiting for locator('[data-testid="new-member-button"]') ============================================================ 49 | await test.step("Can add members", async () => { 50 | // Click [data-testid="new-member-button"] > 51 | await page.locator('[data-testid="new-member-button"]').click(); | ^ 52 | // Fill [placeholder="email\@example\.com"] 53 | await page.locator('[placeholder="email\\@example\\.com"]').fill(inviteeEmail); 54 | // Click [data-testid="invite-new-member-button"] at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/teams.e2e.ts:51:63 at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/teams.e2e.ts:49:16
[@calcom/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members: apps/web/playwright/teams.e2e.ts#L1
1) [@***com/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members Pending operations: - locator.click at apps/web/playwright/teams.e2e.ts:51:63
[@calcom/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members: apps/web/playwright/teams.e2e.ts#L1
1) [@***com/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Test timeout of 60000ms exceeded.
[@calcom/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members: apps/web/playwright/teams.e2e.ts#L51
1) [@***com/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── locator.click: Target closed =========================== logs =========================== waiting for locator('[data-testid="new-member-button"]') ============================================================ 49 | await test.step("Can add members", async () => { 50 | // Click [data-testid="new-member-button"] > 51 | await page.locator('[data-testid="new-member-button"]').click(); | ^ 52 | // Fill [placeholder="email\@example\.com"] 53 | await page.locator('[placeholder="email\\@example\\.com"]').fill(inviteeEmail); 54 | // Click [data-testid="invite-new-member-button"] at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/teams.e2e.ts:51:63 at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/teams.e2e.ts:49:16
[@calcom/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members: apps/web/playwright/teams.e2e.ts#L1
1) [@***com/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Pending operations: - locator.click at apps/web/playwright/teams.e2e.ts:51:63
[@calcom/web] › apps/web/playwright/app-store.e2e.ts:27:7 › App Store - Authed -- legacy › Browse apple-calendar and try to install: apps/web/playwright/fixtures/users.ts#L857
1) [@***com/web] › apps/web/playwright/app-store.e2e.ts:27:7 › App Store - Authed -- legacy › Browse apple-***endar and try to install apiRequestContext.get: read ECONNRESET =========================== logs =========================== → GET http://***:3000/api/auth/csrf user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.5563.19 Safari/537.36 accept: */* accept-encoding: gzip,deflate,br ← 408 Request Timeout connection: close ============================================================ at apps/web/playwright/fixtures/users.ts:857 855 | const csrfToken = await page 856 | .context() > 857 | .request.get("/api/auth/csrf") | ^ 858 | .then((response) => response.json()) 859 | .then((json) => json.csrfToken); 860 | const data = { at apiLogin (/home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/fixtures/users.ts:857:14) at Object.apiLogin (/home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/fixtures/users.ts:588:7) at /home/runner/actions-runner/_work/***.com/***.com/apps/web/playwright/app-store.e2e.ts:29:5
🎭 Playwright Run Summary
1 flaky [@***com/embed-core] › packages/embeds/embed-core/playwright/tests/inline.e2e.ts:8:7 › Inline Iframe › Inline Iframe - Configured with Dark Theme 2 skipped 1 passed (21.4s)
🎭 Playwright Run Summary
1 passed (2.8s)
🎭 Playwright Run Summary
1 skipped 13 passed (41.3s)
🎭 Playwright Run Summary
2 passed (19.6s)
🎭 Playwright Run Summary
1 flaky [@***com/app-store] › packages/app-store/routing-forms/playwright/tests/basic.e2e.ts:325:9 › Routing Forms › Seeded Routing Form › Routing Link should validate fields 5 skipped 7 passed (37.5s)
🎭 Playwright Run Summary
2 flaky [@***com/web] › apps/web/playwright/organization/organization-invitation.e2e.ts:94:9 › Organization › Email not matching orgAutoAcceptEmail › nonexisting user invited to a Team inside organization [@***com/web] › apps/web/playwright/profile.e2e.ts:375:7 › Update Profile › Can resend verification link if the secondary email is unverified 8 skipped 45 passed (1.9m)
🎭 Playwright Run Summary
1 flaky [@***com/web] › apps/web/playwright/login.e2e.ts:16:7 › user can login & logout succesfully -- future › login flow user & logout using dashboard 3 skipped 47 passed (2.3m)
🎭 Playwright Run Summary
1 flaky [@***com/web] › apps/web/playwright/event-types.e2e.ts:250:11 › Event Types tests -- legacy › user › Different Locations Tests › Can remove location from multiple locations that are saved 2 skipped 54 passed (2.4m)
🎭 Playwright Run Summary
1 flaky [@***com/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members 12 skipped 45 passed (2.3m)
🎭 Playwright Run Summary
1 flaky [@***com/web] › apps/web/playwright/app-store.e2e.ts:27:7 › App Store - Authed -- legacy › Browse apple-***endar and try to install 4 skipped 79 passed (3.4m)
Detect changes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Unit tests / test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Linters / lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3, ataylorme/eslint-annotate-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Type check / check-types
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Production build / Build API V1
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Production build / Build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Production build (without database) / Build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Analyze Build / analyze
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3, dawidd6/action-download-artifact@v2, peter-evans/find-comment@v2, peter-evans/create-or-update-comment@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Analyze Build / analyze
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
E2E embeds tests / E2E Embed Core (2/2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
E2E React embeds tests / E2E Embed React (1/2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
E2E embeds tests / E2E Embed Core (1/2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
E2E React embeds tests / E2E Embed React (2/2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
E2E App Store tests / E2E App Store (2/2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
E2E App Store tests / E2E App Store (1/2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
E2E tests / E2E tests (4/5)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
E2E tests / E2E tests (3/5)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
E2E tests / E2E tests (2/5)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
E2E tests / E2E tests (5/5)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
E2E tests / E2E tests (1/5)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, buildjet/setup-node@v3, buildjet/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Artifacts

Produced during runtime
Name Size
app-store-results-1_2 Expired
1.05 MB
app-store-results-2_2 Expired
177 KB
bundle Expired
2.21 KB
embed-core-results-1_2 Expired
186 KB
embed-core-results-2_2 Expired
706 KB
embed-react-results-1_2 Expired
175 KB
embed-react-results-2_2 Expired
173 KB
lint-results Expired
206 KB
test-results-1_5 Expired
602 KB
test-results-2_5 Expired
6.89 MB
test-results-3_5 Expired
6.18 MB
test-results-4_5 Expired
14.7 MB
test-results-5_5 Expired
16.8 MB