fix: conditionally remove fixed prop if we're in embed #14586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
embed
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
consumer
Medium priority
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/15/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Current Playwright Test Results Summary✅ 302 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/15/2024 11:50:22am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: cc6b61c Started: 04/15/2024 11:46:22am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2 • Retry 1 • Initial Attempt |
8.50% (25)25 / 294 runsfailed over last 7 days |
36.73% (108)108 / 294 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0% (0)0 / 279 runsfailed over last 7 days |
19.71% (55)55 / 279 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
4.38% (12)12 / 274 runsfailed over last 7 days |
30.66% (84)84 / 274 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to a Team inside organization
Retry 1 • Initial Attempt |
1.74% (5)5 / 287 runsfailed over last 7 days |
15.33% (44)44 / 287 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can resend verification link if the secondary email is unverified
Retry 1 • Initial Attempt |
2.13% (6)6 / 282 runsfailed over last 7 days |
13.12% (37)37 / 282 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1 • Initial Attempt |
0.35% (1)1 / 282 runfailed over last 7 days |
5.67% (16)16 / 282 runsflaked over last 7 days |
📄 apps/web/playwright/app-store.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
App Store - Authed -- legacy Browse apple-calendar and try to install
Retry 1 • Initial Attempt |
0% (0)0 / 292 runsfailed over last 7 days |
1.37% (4)4 / 292 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.71% (2)2 / 282 runsfailed over last 7 days |
53.55% (151)151 / 282 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
sean-brydon
deleted the
sean/cal-3049-fix-not-using-abosulte-ui-elements-instant-meeting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #13456
fixes: CAL-3049
Currently in embed monthly view - this instant meeting element doesnt increase the size of the booker and can block the events for a user to select
Embed:
Monthly View
Weekly View
Normal Monthly View
