Fix crash due to some props being undefined (#4427)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
calcom · Sep 14, 2022 · 2f9905e · 2f9905e
1 parent ab4d910
commit 2f9905e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/apps/web/pages/v2/settings/my-account/conferencing.tsx b/apps/web/pages/v2/settings/my-account/conferencing.tsx
@@ -120,11 +120,11 @@ export const getServerSideProps = async (context: GetServerSidePropsContext) =>
     .map((app) => {
       return {
         slug: app.slug,
-        title: app.title,
+        title: app.title || app.name,
         logo: app.logo,
         description: app.description,
         credentialId: app.credentials[0].id,
-        isGlobal: app.isGlobal,
+        isGlobal: app.isGlobal || false,
       };
     });
 

diff --git a/packages/app-store/riverside/config.json b/packages/app-store/riverside/config.json
@@ -1,7 +1,6 @@
 {
   "/*": "Don't modify slug - If required, do it using cli edit command",
-  "name": "riverside",
-  "title": "Riverside",
+  "name": "Riverside",
   "slug": "riverside",
   "type": "riverside_video",
   "imageSrc": "/api/app-store/riverside/icon.svg",

diff --git a/packages/types/App.d.ts b/packages/types/App.d.ts
@@ -54,7 +54,12 @@ export interface App {
     | `${string}_web3`
     | `${string}_other`
     | `${string}_other_calendar`;
-  /** The display name for the app, TODO settle between this or name */
+
+  /**
+   * @deprecated
+   *
+   * Use name instead. Remove this property after ensuring name has the required value everywhere
+   * */
   title?: string;
   /** The display name for the app */
   name: string;