Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAL-2128] Embed Code Snippet Generator should use event slug as namespace for API #10031

Closed
hariombalhara opened this issue Jul 10, 2023 · 1 comment · Fixed by #11512
Closed

[CAL-2128] Embed Code Snippet Generator should use event slug as namespace for API #10031

hariombalhara opened this issue Jul 10, 2023 · 1 comment · Fixed by #11512
Assignees
@hariombalhara
Labels
embed area: embed, widget, react embed ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync
Milestone
v3.6

Comments

@hariombalhara
Copy link
Member

hariombalhara commented Jul 10, 2023 •
edited

Using event slug as namespace for the generated code would allow users to have more than 1 embed on a single page without making any changes to the code snippet.

This is a problem faced by a user as reported in Discord

CAL-2128
@hariombalhara hariombalhara self-assigned this Jul 10, 2023
@hariombalhara hariombalhara changed the title Embed Code Snippet Generator should use event slug as namespace for API [CAL-2128] Embed Code Snippet Generator should use event slug as namespace for API Jul 10, 2023
@maige-app maige-app bot added ✨ feature New feature or request embed area: embed, widget, react embed labels Jul 10, 2023
@PeerRich PeerRich added the Medium priority Created by Linear-GitHub Sync label Jul 10, 2023
@hariombalhara hariombalhara mentioned this issue Aug 7, 2023
Closed
@github-actions github-actions bot added the Stale label Sep 9, 2023
@hariombalhara hariombalhara added this to the v3.4 milestone Sep 25, 2023
@hariombalhara hariombalhara mentioned this issue Sep 25, 2023
Merged
2 tasks
@github-actions github-actions bot removed the Stale label Sep 26, 2023
@keithwillcode keithwillcode modified the milestones: v3.4, v3.5 Oct 17, 2023
@keithwillcode keithwillcode removed this from the v3.5 milestone Nov 10, 2023
@keithwillcode
Copy link
Contributor

Removing from milestone because PR went stale.

@hariombalhara hariombalhara added this to the v3.6 milestone Dec 11, 2023
@hariombalhara hariombalhara mentioned this issue Feb 12, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hariombalhara hariombalhara

Labels
embed area: embed, widget, react embed ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
v3.6
Development

Successfully merging a pull request may close this issue.

fix: Enhance the Robustness of Embed Snippets for Multiple Embeds on a Single Page calcom/cal.com
3 participants
@hariombalhara @keithwillcode @PeerRich