Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Errors due to namespacing of embed #13637

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Feb 12, 2024

What does this PR do?

Fixes #13501

  • Avoid distributing namespaced embed snippet as there are some bugs in it
  • Also, remove faulty check of inline embed existence. DOM can be out of sync with in memory tracking of existence.

It effectively reopens #10031. But namespacing, by default, will make a comeback in #13386 after making sure all scenarios are tested.

Important

Users need to re-copy the snippets from the app to get it working. This is applicable to react as well as vanilla JS snippets.

Before (React)
image

After(React)
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 11:35am
api 🔄 Building (Inspect) Visit Preview Feb 12, 2024 11:35am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Feb 12, 2024 11:35am
cal-demo ⬜️ Ignored (Inspect) Feb 12, 2024 11:35am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 11:35am
ui ⬜️ Ignored (Inspect) Feb 12, 2024 11:35am

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 12, 2024
@hariombalhara hariombalhara self-assigned this Feb 12, 2024
@hariombalhara hariombalhara marked this pull request as ready for review February 12, 2024 11:36
@hariombalhara hariombalhara changed the title Remove namespacing by default and also revert restriction in embeddin… fix: Errors due to namespacing of embed Feb 12, 2024
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/settings/my-account/out-of-office 269.7 KB 457.84 KB 130.81% (🟢 -1.77%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

deploysentinel bot commented Feb 12, 2024

Current Playwright Test Results Summary

✅ 63 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/12/2024 12:01:51pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: c28aeee

Started: 02/12/2024 11:59:39am UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1Initial Attempt
0% (0) 0 / 125 runs
failed over last 7 days
50.40% (63) 63 / 125 runs
flaked over last 7 days
Update Profile Can update a users email (verification enabled)
Retry 2Retry 1Initial Attempt
13.33% (18) 18 / 135 runs
failed over last 7 days
53.33% (72) 72 / 135 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich added the High priority Created by Linear-GitHub Sync label Feb 12, 2024
@PeerRich PeerRich added this to the v3.8 milestone Feb 12, 2024
@zomars zomars merged commit 7cffb30 into main Feb 12, 2024
44 of 46 checks passed
@zomars zomars deleted the remove-namespacing-usage branch February 12, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3075] @calcom/embed-react error: Uncaught (in promise) TypeError: cal.ns.x is not a function
4 participants