-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Errors due to namespacing of embed #13637
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 63 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/12/2024 12:01:51pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: c28aeee Started: 02/12/2024 11:59:39am UTC
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
0% (0)0 / 125 runsfailed over last 7 days |
50.40% (63)63 / 125 runsflaked over last 7 days |
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt |
13.33% (18)18 / 135 runsfailed over last 7 days |
53.33% (72)72 / 135 runsflaked over last 7 days |
What does this PR do?
Fixes #13501
It effectively reopens #10031. But namespacing, by default, will make a comeback in #13386 after making sure all scenarios are tested.
Important
Users need to re-copy the snippets from the app to get it working. This is applicable to react as well as vanilla JS snippets.
Before (React)
![image](https://private-user-images.githubusercontent.com/1780212/304051902-4b0690c6-2fc6-4173-9367-e65eed8de35a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1ODg0NTgsIm5iZiI6MTcyMTU4ODE1OCwicGF0aCI6Ii8xNzgwMjEyLzMwNDA1MTkwMi00YjA2OTBjNi0yZmM2LTQxNzMtOTM2Ny1lNjVlZWQ4ZGUzNWEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjFUMTg1NTU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWFmNTk5NmE2N2NmYWY1NDM3NDk4NjBlNDRiYzY2MDczYjM0MDVkZmY1MjI2NTY0OGY4NmI1Mzk2ZTZjZTU4MCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Kp4g467ju4MQgkjIJ2yfqpOtCH0PS6EtRMo3h__Teek)
After(React)
![image](https://private-user-images.githubusercontent.com/1780212/304051128-9b7bba5a-0f7c-42d3-9026-954f2ed87df1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1ODg0NTgsIm5iZiI6MTcyMTU4ODE1OCwicGF0aCI6Ii8xNzgwMjEyLzMwNDA1MTEyOC05YjdiYmE1YS0wZjdjLTQyZDMtOTAyNi05NTRmMmVkODdkZjEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjFUMTg1NTU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Mzk3NDI1Mzk2YjgxMWQyNDI0MTlmYjY1NDk1ZGE4MGFjMTY5MmEwNWZjOGQ2ZmU2MDVhMjQ3MzdhMjZlNzY0MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.uCTmW2BqS965nCp_9X_dWJwYKa8wgSq83I4laZ9RZHs)
Type of change
Mandatory Tasks
Checklist