Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-2635] make cal.com dockerable – refactor constant.ts #12032

Open
PeerRich opened this issue Oct 23, 2023 · 2 comments · May be fixed by #13541
Open

[CAL-2635] make cal.com dockerable – refactor constant.ts #12032

PeerRich opened this issue Oct 23, 2023 · 2 comments · May be fixed by #13541
Assignees
Labels
ci area: CI, DX, pipeline, github actions community Created by Linear-GitHub Sync docker foundation Medium priority Created by Linear-GitHub Sync osshack Submission for 2023 OSShack platform Anything related to our platform plan
Milestone

Comments

@PeerRich
Copy link
Member

PeerRich commented Oct 23, 2023

core issue:

  • environment variables should not end up in build output
  • all environment variables should be runtime only

problem:

From SyncLinear.com | CAL-2635

@maige-app maige-app bot added platform Anything related to our platform plan docker labels Oct 23, 2023
@PeerRich PeerRich changed the title make cal.com dockerable – refactor constant.ts [CAL-2635] make cal.com dockerable – refactor constant.ts Oct 23, 2023
@PeerRich PeerRich added Medium priority Created by Linear-GitHub Sync ci area: CI, DX, pipeline, github actions labels Oct 23, 2023
@zomars zomars added the osshack Submission for 2023 OSShack label Dec 2, 2023
@Drex72
Copy link

Drex72 commented Dec 3, 2023

So quick question @PeerRich , are we supposed to create a new docker image that doesnt allow environment variables to end up in build output, or we're meant to fix the existing docker image?

@mbaraa
Copy link

mbaraa commented Dec 3, 2023

hey, can I be assigned?
I opened this PR in the docker repository, should I open an issue there there or what.

@PeerRich PeerRich added the community Created by Linear-GitHub Sync label Jan 10, 2024
@PeerRich PeerRich added this to the v3.8 milestone Jan 10, 2024
@keithwillcode keithwillcode modified the milestones: v3.8, v3.9 Jan 29, 2024
@PeerRich PeerRich modified the milestones: v3.9, v4.0 Mar 16, 2024
@keithwillcode keithwillcode modified the milestones: v4.0, v4.1 Apr 15, 2024
@PeerRich PeerRich modified the milestones: v4.1, v4.2 May 15, 2024
@keithwillcode keithwillcode modified the milestones: v4.2, v4.3 Jun 17, 2024
@keithwillcode keithwillcode modified the milestones: v4.3, v4.4 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci area: CI, DX, pipeline, github actions community Created by Linear-GitHub Sync docker foundation Medium priority Created by Linear-GitHub Sync osshack Submission for 2023 OSShack platform Anything related to our platform plan
Projects
None yet
6 participants