Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: makes production build ready for docker #12686

Closed

Conversation

adrian-d-hidalgo
Copy link

What does this PR do?

This PR modifies how you can use environment variables on runtime to have "one build, many deployments". With this update, you can now build Docker images, so anybody can deploy with their own environments.

This fix allows PR #313 to work correctly.

Fixes #12032

Requirement/Documentation

  • No extra requirements needed

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Follow README.md instructions to build for production
  • The repository may have some build Issues that should be attended to fix some types of errors, meanwhile, you can run DISABLE_ESLINT_PLUGIN=true NODE_ENV=production CI=true yarn build to avoid those errors
  • Run yarn start to test

Copy link

vercel bot commented Dec 5, 2023

@alannnc is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ alannnc
❌ Adrián Darío Hidalgo Flores


Adrián Darío Hidalgo Flores seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions github-actions bot added ci area: CI, DX, pipeline, github actions docker Medium priority Created by Linear-GitHub Sync osshack Submission for 2023 OSShack platform Anything related to our platform plan labels Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 163.8 KB (🟡 +612 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@adrian-d-hidalgo adrian-d-hidalgo changed the title Fix production build chore: makes production build ready for docker Dec 5, 2023
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the proposal seems to be simple and fair. We cannot merge any of these until all of the checks are passing.

The repository may have some build Issues that should be attended to fix some types of errors, meanwhile, you can run DISABLE_ESLINT_PLUGIN=true NODE_ENV=production CI=true yarn build to avoid those errors

We cannot allow this on main unfortunately.

Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added Stale and removed Stale labels Dec 22, 2023
Copy link
Contributor

github-actions bot commented Jan 6, 2024

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Jan 6, 2024
@keithwillcode keithwillcode added this to the v3.8 milestone Jan 10, 2024
@github-actions github-actions bot removed the Stale label Jan 11, 2024
@keithwillcode keithwillcode added the community Created by Linear-GitHub Sync label Jan 11, 2024
Copy link
Contributor

Hey there, there is a merge conflict, can you take a look?

@github-actions github-actions bot added the 🚨 merge conflict This PR has a merge conflict that has to be addressed label Jan 23, 2024
@keithwillcode keithwillcode requested a review from a team January 24, 2024 15:24
@keithwillcode keithwillcode added foundation and removed platform Anything related to our platform plan labels Jan 24, 2024
@keithwillcode keithwillcode modified the milestones: v3.8, v3.9 Jan 29, 2024
@keithwillcode keithwillcode marked this pull request as draft January 29, 2024 15:16
@keithwillcode
Copy link
Contributor

Converting to draft while conflicts are fixed

Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Feb 13, 2024
@keithwillcode
Copy link
Contributor

Closing in favor of #13541

@keithwillcode keithwillcode modified the milestones: v3.9, v3.8 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci area: CI, DX, pipeline, github actions community Created by Linear-GitHub Sync docker foundation Medium priority Created by Linear-GitHub Sync 🚨 merge conflict This PR has a merge conflict that has to be addressed osshack Submission for 2023 OSShack Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2635] make cal.com dockerable – refactor constant.ts
5 participants