fix: production ready docker build with ci workflow #13541
Conversation
|
chichi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
ci
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
Wow, thanks so much for this contribution, @ChichiCaleb. We’ve slotted it to be reviewed during the 3.9 milestone which starts the 15th. 🙏🏼 |
|
thanks for the great work this community has been doing |
|
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
ChichiCaleb
changed the title
ChichiCaleb
changed the title
ChichiCaleb
changed the title
|
If we merge this PR means that the calcom/docker repo would be deprecated? |
|
@emrysal have you seen this PR? I know you've been experimenting with the docker builds. |
|
its interesting that this keeps getting pushed forward... |
PeerRich
added
High priority
keithwillcode
added
Medium priority
What does this PR do?
builds a production ready docker image
builds a leaner and more secure docker image (< 1/3) the size of the current calcom image
abilty to change host and any chosen inlined build time variable with runtime variable
db migration at runtime
implemented postgres healthcheck and service_healthy option in compose removing the need for wait-for-it script
ability to run unit test in docker
builds a full featured ci with ability to:
build a test image and push to GHCR which will subequently be pulled by integration-test
and trivy scan jobs for their respective actions
builds and runs unit test specified in the repo by targeting unit-test layer of multistage docker build
however uses the cache from test image to save time
pulls test image from GHCR and runs integration test in docker compose
pulls test image from GHCR and run a trivy vulnerability scan for high and crtical CVEs (non-blocking)
and uploads the sarif result to github security tab
generates changelog.MD file and create releases using conventional commits.
creates a prelease when a pull request is made to main branch following a succesful unit and integration test.
creates a release when a merge is made to the main branch and adds either the prelease or released version to github output to be used by final image published to docker hub
builds the final image and adds latest tag and
image:V*.*.*semantic versioning tag to merge requestand
image:v*.*.*-alpha.*tag to pull requests made to main branch before pushing to dockerhubadds the Docker image tag(s)/labels pushed to docker hub,to the pull request comment section for reference purpose
Fixes #12032
Requirement/Documentation
In repo settings under actions enable:
create a github Personal access Token and add as repo secret with the name RELEASE_MAIN for automated
changelog generation and release enabling the following:
In repo settings under rules enable:
Type of change
How should this be tested?
Duplicate
.env.exampleto.envin infra/docker/webA workflow flow run, pull request or merge request triggers the ci workflow
start the services in docker compose and test locally with:
Mandatory Tasks