Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAL-3368] Private link for a team event gives 404 if there are no users assigned to team event #14456

Closed
hariombalhara opened this issue Apr 8, 2024 · 0 comments · Fixed by #14473
Closed

[CAL-3368] Private link for a team event gives 404 if there are no users assigned to team event #14456

hariombalhara opened this issue Apr 8, 2024 · 0 comments · Fixed by #14473
Labels
🐛 bug Something isn't working Private Created by Linear-GitHub Sync teams area: teams, round robin, collective, managed event-types

Comments

@hariombalhara
Copy link
Member

From SyncLinear.com | CAL-3368
@dosubot dosubot bot added Private Created by Linear-GitHub Sync teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Apr 8, 2024
@Amit91848 Amit91848 mentioned this issue Apr 9, 2024
Merged
1 task
zomars pushed a commit that referenced this issue Apr 10, 2024
@Amit91848
fix: private link for a team event gives 404 (#14473)
68c4ad2 
## What does this PR do?

Fixes #14456 

https://github.com/calcom/cal.com/blob/65df5ac0e4086422bc0b8416f16ba991a10e785d/apps/web/lib/d/%5Blink%5D/%5Bslug%5D/getServerSideProps.tsx#L52-L60

For team events there is no username, so it was returning 404 irrespective of whether anyone was assigned or not.

https://github.com/calcom/cal.com/assets/74371312/b4c8c592-4132-4040-acb2-db37f8f152d6




## Type of change

<!-- Please delete bullets that are not relevant. -->

- Bug fix (non-breaking change which fixes an issue)


## Mandatory Tasks

- [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working Private Created by Linear-GitHub Sync teams area: teams, round robin, collective, managed event-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: private link for a team event gives 404 Amit91848/cal.com
1 participant
@hariombalhara