Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: private link for a team event gives 404 #14473

Merged

Conversation

Amit91848
Copy link
Contributor

What does this PR do?

Fixes #14456

const username = hashedLink?.eventType.users[0]?.username;
const notFound = {
notFound: true,
} as const;
if (!hashedLink || !username) {
return notFound;
}

For team events there is no username, so it was returning 404 irrespective of whether anyone was assigned or not.

Screen.Recording.2024-04-09.at.2.59.26.PM.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Apr 9, 2024

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 9, 2024
@graphite-app graphite-app bot requested a review from a team April 9, 2024 09:57
@github-actions github-actions bot added Private Created by Linear-GitHub Sync teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Apr 9, 2024
@dosubot dosubot bot added core area: core, team members only event-types area: event types, event-types High priority Created by Linear-GitHub Sync labels Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

graphite-app bot commented Apr 9, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (04/09/24)

1 label was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode removed the Private Created by Linear-GitHub Sync label Apr 9, 2024
@keithwillcode keithwillcode added this to the v4.0 milestone Apr 9, 2024
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zomars zomars merged commit 68c4ad2 into calcom:main Apr 10, 2024
31 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync core area: core, team members only event-types area: event types, event-types High priority Created by Linear-GitHub Sync teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3368] Private link for a team event gives 404 if there are no users assigned to team event
3 participants