Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12/24h time format on booking page not updating according to settings page when app runs on different (sub)domain #4851

Closed
JeroenReumkens opened this issue Oct 5, 2022 · 2 comments · Fixed by #4865
Labels
🐛 bug Something isn't working
Milestone

Comments

@JeroenReumkens
Copy link
Contributor

Issue Summary

In #4771 we did a fix to ensure that your 12/24 time formats where honoured on the bookings page. The solution however is not working on cal.com. The reason is the settings page lives on app.cal.com and the public booking page on cal.com/..... Because of that the localstorage set on the settings page will be set on the subdomain and won't be updated on the root domain.

Steps to Reproduce

  1. Update your 12/24h time format on https://app.cal.com/settings/my-account/general
  2. Go to a public bookings page
  3. Conclude that the 12/24h format isn't honoured
  4. If you're more technical: Note that the localstorage item timeOption.is24hClock isn't updated either.
@PeerRich PeerRich added 🚨 urgent 🐛 bug Something isn't working labels Oct 5, 2022
@Toledodev
Copy link
Contributor

Toledodev commented Oct 5, 2022

Hey @PeerRich @JeroenReumkens How we can test this? I'm trying to solve this problem but how can I check?

@PeerRich PeerRich added this to the v.2.1 milestone Oct 5, 2022
@PeerRich
Copy link
Member

PeerRich commented Oct 5, 2022

this is a different problem. the settings page was never meant to change the booking page.

the booking page should use the user agent

@PeerRich PeerRich closed this as completed Oct 5, 2022
JeroenReumkens added a commit that referenced this issue Oct 6, 2022
… logged in. Also hides timeformat toggle on booking page for logged in users. For non loggedin users we still infer by looking at browser timezone, after that we set a localstorage which we will look at, and which will get updated when the user updates the toggle in the timezone dropdown.
PeerRich pushed a commit that referenced this issue Oct 6, 2022
… logged in. Also hides timeformat toggle on booking page for logged in users. For non loggedin users we still infer by looking at browser timezone, after that we set a localstorage which we will look at, and which will get updated when the user updates the toggle in the timezone dropdown. (#4865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants