fix: Handle disabling of ORGANIZATIONS_ENABLED correctly. #11041

hariombalhara · 2023-08-31T10:40:50Z

What does this PR do?

Improve ORGANIZATIONS_ENABLED check so that it is only enabled when it is set to "1" or "true" as per the comment. It allows disabling it by setting it to "0" or "false"
Adding header logging for redirects only when the env variable is enabled to avoid false logs.

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Simply go to app.cal.local:3000 with the env variable disabled and verify that the headers starting with X-Cal-Org aren't showing up.
Enable the env variable and repeat the test to see that now they are visible.

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

vercel · 2023-08-31T10:40:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 31, 2023 10:52am
cal	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 31, 2023 10:52am
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 31, 2023 10:52am
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 31, 2023 10:52am
ui	❌ Failed (Inspect)			Aug 31, 2023 10:52am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
qa	⬜️ Ignored (Inspect)	Visit Preview		Aug 31, 2023 10:52am

github-actions · 2023-08-31T10:41:04Z

Thank you for following the naming conventions! 🙏

hariombalhara · 2023-08-31T10:42:49Z

apps/web/next.config.js

@@ -226,7 +227,7 @@ const nextConfig = {
  async rewrites() {
    const beforeFiles = [
      // These rewrites are other than booking pages rewrites and so that they aren't redirected to org pages ensure that they happen in beforeFiles
-      ...(process.env.ORGANIZATIONS_ENABLED


Earlier we were checking the emptiness of the env variable and thus there was no way to disable it by setting it to 0 or false

hariombalhara · 2023-08-31T10:44:12Z

apps/web/next.config.js

@@ -333,44 +334,46 @@ const nextConfig = {
          },
        ],
      },
-      ...[


Add the logging headers only when the redirect is actually happening. Same check is already there for redirects.

github-actions · 2023-08-31T10:50:02Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seventeen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/apps/[slug]/[...pages]`	`538.6 KB`	693.95 KB	198.27% (🟢 -0.18%)
`/availability/[schedule]`	`344.4 KB`	499.75 KB	142.79% (🟢 -0.27%)
`/event-types`	`520.44 KB`	675.79 KB	193.08% (🟢 -0.19%)
`/event-types/[type]`	`373.33 KB`	528.68 KB	151.05% (🟢 -0.17%)
`/org/[orgSlug]`	`220.02 KB`	375.37 KB	107.25% (🟢 -0.32%)
`/org/[orgSlug]/[user]`	`226.28 KB`	381.63 KB	109.04% (🟢 -0.32%)
`/org/[orgSlug]/team/[slug]`	`220.02 KB`	375.38 KB	107.25% (🟢 -0.32%)
`/settings/organizations/teams/other/[id]/profile`	`441.04 KB`	596.39 KB	170.40% (🟢 -0.29%)
`/settings/security/two-factor-auth`	`255.04 KB`	410.39 KB	117.26% (🟢 -0.25%)
`/settings/teams/[id]/members`	`371.18 KB`	526.53 KB	150.44% (🟢 -0.17%)
`/settings/teams/[id]/profile`	`441.42 KB`	596.77 KB	170.51% (🟢 -0.29%)
`/signup`	`109.32 KB`	264.67 KB	75.62% (🟢 -4.34%)
`/team/[slug]`	`219.95 KB`	375.3 KB	107.23% (🟢 -0.32%)
`/team/[slug]/embed`	`220.02 KB`	375.37 KB	107.25% (🟢 -0.32%)
`/video/[uid]`	`234.76 KB`	390.11 KB	111.46% (🟢 -0.23%)
`/workflows`	`277.21 KB`	432.56 KB	123.59% (🟢 -0.16%)
`/workflows/[workflow]`	`390.65 KB`	546 KB	156.00% (🟢 -0.17%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

deploysentinel · 2023-08-31T10:51:09Z

Current Playwright Test Results Summary

✅ 122 Passing - ⚠️ 6 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/31/2023 10:52:42am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 81116ab

Started: 08/31/2023 10:50:28am UTC

⚠️ Flakes

📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA Retry 1 • Initial Attempt	0.86% (2) 2 / 233 runs failed over last 7 days	31.76% (74) 74 / 233 runs flaked over last 7 days

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration When event is paid and confirmed Cancelled paid booking should be refunded Retry 1 • Initial Attempt	0% (0) 0 / 221 runs failed over last 7 days	9.50% (21) 21 / 221 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 2 • Retry 1 • Initial Attempt	6.42% (17) 17 / 265 runs failed over last 7 days	93.21% (247) 247 / 265 runs flaked over last 7 days

📄 apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Reschedule Tests Should do a booking request reschedule from /bookings Retry 1 • Initial Attempt	0% (0) 0 / 263 runs failed over last 7 days	0.76% (2) 2 / 263 runs flaked over last 7 days

📄 packages/app-store/typeform/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download Retry 1 • Initial Attempt	0.39% (1) 1 / 257 run failed over last 7 days	6.23% (16) 16 / 257 runs flaked over last 7 days

📄 apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
FORM_SUBMITTED can submit a form and get a submission event Retry 1 • Initial Attempt	1.65% (4) 4 / 243 runs failed over last 7 days	29.22% (71) 71 / 243 runs flaked over last 7 days

View Detailed Build Results

leog

Great catch, thanks for taking care of this.

* Add loading data and banner * [WIP] hasEditPerms middleware * fix: type error in booker (#11011) * New Crowdin translations by Github Action * refactor: removed redundant test (#10785) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com> * feat: 2fa backup codes (#10600) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * Delete add-PRs-to-project-reviewing-PRs.yml (#11008) Co-authored-by: alannnc <alannnc@gmail.com> * New Crowdin translations by Github Action * fix: multiple duration when booking (#11032) * fix: other reported issues (#11015) * fix: weird margin top in avatar * fix: pending users are shown on booking page * fix: avatar and naming issues * fix: toast alignment and removing unneeded titles * missing changes from toast improvements * feat: empty state for teams without event types * Removing console.log * feat: cal ai (#10992) Co-authored-by: nicktrn <55853254+nicktrn@users.noreply.github.com> Co-authored-by: tedspare <ted.spare@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> * New Crowdin translations by Github Action * fix: meeting ended trigger for webhooks and zapier sometimes not working (#10946) Co-authored-by: mohammed gehad <mohammed.gehad.1998@gmail.com> Co-authored-by: Monto <138862352+monto7926@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> * feat: team admin: see connected apps of team members (#11036) * added feature:team admin can see connected apps of members * fixed the type error * Update packages/lib/server/queries/teams/index.ts * Minor fixes --------- Co-authored-by: alannnc <alannnc@gmail.com> * fix: lower case slugs in teams (#11026) * fix: lower case slugs in teams Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * fix: use slugify Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * refactor: improvements on german translation (#10898) * fix: fix-tablet-menu-not-centered-sidebar (#11020) Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * chore: add Popover in storybook (#11021) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * fix: Set mobile availability (#11027) * chore: add ColorPicker in storybook (CALCOM-10760) (#10866) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * feat: adds next cold start profiler (#11014) * Handle disabling of ORGANIZATIONS_ENABLED flag (#11041) * New Crowdin translations by Github Action * styles:dark mode color fix (#11004) * chore: sheet darkmode and improve responsive (#11047) * fix: handle collective multiple host on destinationCalendar (#10967) * fix: include app data and credentials from DB (#11048) * include app data and credentials from DB * Improve performance * fix: Error when running storybook (#11037) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * fix: broken company profile link on team booking page (#10978) * chore: add ErrorBoundary in storybook (CALCOM-10760) (#10872) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * feat: sorting for workflow and routing forms (#10780) Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * resolve zod versions across child packages (#11052) * fix: List storybook file is empty (fix-list) (#10965) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: admin org list without members (#11051) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * chore: add ToggleGroup in storybook (#10802) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> * fix: add metadata to stripe payment intent (#11053) * fix: Logo storybook file with invalid icons (fix-logo) (#11018) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: Add controls for Select Field storybook file (#10936) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: Fix tooltip control on ButtonPlayground storybook file (fix-ButtonTooltip) (#10937) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: email embed – remove collapsible and permanently show times (#10996) Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Mehul <mehulzr@gmail.com> * chore: add Timezone Select in storybook (CALCOM-10760) (#10966) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * chore: add Switch in storybook (CALCOM-10760) (#10804) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * Sync packages * fix: zod utils due to upgrade * easy fix (#11054) * fix sub quantity update stripe (#11057) * v3.2.7 * Revert "feat: adds next cold start profiler (#11014)" (#11072) This reverts commit 05631d0. * fix: Fixes username invite issue (#10998) * Fixes username invite issue * Ensure we only suggest email invites in org members --------- Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * Fix sheet layout * WIP permissions when userschedule doesnt match * WIP get handler weird behaviour * Update toast * add disabled - handle membership overlap * Handle permissions + perf improvments * use input uid * Remove Console.log * Clean up * Revert changes accidental * Fix merge artifacts * Remove dead code * Remove code after return * Update read permission check * Revert avatar changes as fixed elsewhere * Handle if user has not completed onboarding * Disable button * Update packages/lib/hasEditPermissionForUser.ts * Correct Error throwing * Update packages/features/timezone-buddy/components/AvailabilityEditSheet.tsx * Fix type erro * Add i18n * Improve Spacing * Update yarn.lock --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: GitStart-Cal.com <121884634+gitstart-calcom@users.noreply.github.com> Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com> Co-authored-by: nicktrn <55853254+nicktrn@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Leo Giovanetti <hello@leog.me> Co-authored-by: DexterStorey <36115192+DexterStorey@users.noreply.github.com> Co-authored-by: tedspare <ted.spare@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Monto <138862352+montocoder@users.noreply.github.com> Co-authored-by: mohammed gehad <mohammed.gehad.1998@gmail.com> Co-authored-by: Monto <138862352+monto7926@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: Abhijeet Singh <asingh9829@gmail.com> Co-authored-by: Kamil B. Demirci <kamil.demirci@indyaner.ch> Co-authored-by: Denzil Samuel <71846487+samueldenzil@users.noreply.github.com> Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Co-authored-by: Omar López <zomars@me.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Sahil Padvi <71093044+Sahil25061999@users.noreply.github.com> Co-authored-by: Patel Divyesh <pateldivyesh1323@gmail.com> Co-authored-by: neo773 <62795688+neo773@users.noreply.github.com> Co-authored-by: Mehul <mehulzr@gmail.com>

* Add loading data and banner * [WIP] hasEditPerms middleware * fix: type error in booker (calcom#11011) * New Crowdin translations by Github Action * refactor: removed redundant test (calcom#10785) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com> * feat: 2fa backup codes (calcom#10600) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * Delete add-PRs-to-project-reviewing-PRs.yml (calcom#11008) Co-authored-by: alannnc <alannnc@gmail.com> * New Crowdin translations by Github Action * fix: multiple duration when booking (calcom#11032) * fix: other reported issues (calcom#11015) * fix: weird margin top in avatar * fix: pending users are shown on booking page * fix: avatar and naming issues * fix: toast alignment and removing unneeded titles * missing changes from toast improvements * feat: empty state for teams without event types * Removing console.log * feat: cal ai (calcom#10992) Co-authored-by: nicktrn <55853254+nicktrn@users.noreply.github.com> Co-authored-by: tedspare <ted.spare@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> * New Crowdin translations by Github Action * fix: meeting ended trigger for webhooks and zapier sometimes not working (calcom#10946) Co-authored-by: mohammed gehad <mohammed.gehad.1998@gmail.com> Co-authored-by: Monto <138862352+monto7926@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> * feat: team admin: see connected apps of team members (calcom#11036) * added feature:team admin can see connected apps of members * fixed the type error * Update packages/lib/server/queries/teams/index.ts * Minor fixes --------- Co-authored-by: alannnc <alannnc@gmail.com> * fix: lower case slugs in teams (calcom#11026) * fix: lower case slugs in teams Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * fix: use slugify Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * refactor: improvements on german translation (calcom#10898) * fix: fix-tablet-menu-not-centered-sidebar (calcom#11020) Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * chore: add Popover in storybook (calcom#11021) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * fix: Set mobile availability (calcom#11027) * chore: add ColorPicker in storybook (CALCOM-10760) (calcom#10866) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * feat: adds next cold start profiler (calcom#11014) * Handle disabling of ORGANIZATIONS_ENABLED flag (calcom#11041) * New Crowdin translations by Github Action * styles:dark mode color fix (calcom#11004) * chore: sheet darkmode and improve responsive (calcom#11047) * fix: handle collective multiple host on destinationCalendar (calcom#10967) * fix: include app data and credentials from DB (calcom#11048) * include app data and credentials from DB * Improve performance * fix: Error when running storybook (calcom#11037) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * fix: broken company profile link on team booking page (calcom#10978) * chore: add ErrorBoundary in storybook (CALCOM-10760) (calcom#10872) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * feat: sorting for workflow and routing forms (calcom#10780) Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * resolve zod versions across child packages (calcom#11052) * fix: List storybook file is empty (fix-list) (calcom#10965) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: admin org list without members (calcom#11051) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * chore: add ToggleGroup in storybook (calcom#10802) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> * fix: add metadata to stripe payment intent (calcom#11053) * fix: Logo storybook file with invalid icons (fix-logo) (calcom#11018) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: Add controls for Select Field storybook file (calcom#10936) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: Fix tooltip control on ButtonPlayground storybook file (fix-ButtonTooltip) (calcom#10937) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> * fix: email embed – remove collapsible and permanently show times (calcom#10996) Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Mehul <mehulzr@gmail.com> * chore: add Timezone Select in storybook (CALCOM-10760) (calcom#10966) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * chore: add Switch in storybook (CALCOM-10760) (calcom#10804) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> * Sync packages * fix: zod utils due to upgrade * easy fix (calcom#11054) * fix sub quantity update stripe (calcom#11057) * v3.2.7 * Revert "feat: adds next cold start profiler (calcom#11014)" (calcom#11072) This reverts commit 05631d0. * fix: Fixes username invite issue (calcom#10998) * Fixes username invite issue * Ensure we only suggest email invites in org members --------- Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * Fix sheet layout * WIP permissions when userschedule doesnt match * WIP get handler weird behaviour * Update toast * add disabled - handle membership overlap * Handle permissions + perf improvments * use input uid * Remove Console.log * Clean up * Revert changes accidental * Fix merge artifacts * Remove dead code * Remove code after return * Update read permission check * Revert avatar changes as fixed elsewhere * Handle if user has not completed onboarding * Disable button * Update packages/lib/hasEditPermissionForUser.ts * Correct Error throwing * Update packages/features/timezone-buddy/components/AvailabilityEditSheet.tsx * Fix type erro * Add i18n * Improve Spacing * Update yarn.lock --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: GitStart-Cal.com <121884634+gitstart-calcom@users.noreply.github.com> Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com> Co-authored-by: nicktrn <55853254+nicktrn@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Leo Giovanetti <hello@leog.me> Co-authored-by: DexterStorey <36115192+DexterStorey@users.noreply.github.com> Co-authored-by: tedspare <ted.spare@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Monto <138862352+montocoder@users.noreply.github.com> Co-authored-by: mohammed gehad <mohammed.gehad.1998@gmail.com> Co-authored-by: Monto <138862352+monto7926@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: Abhijeet Singh <asingh9829@gmail.com> Co-authored-by: Kamil B. Demirci <kamil.demirci@indyaner.ch> Co-authored-by: Denzil Samuel <71846487+samueldenzil@users.noreply.github.com> Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Co-authored-by: Omar López <zomars@me.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Sahil Padvi <71093044+Sahil25061999@users.noreply.github.com> Co-authored-by: Patel Divyesh <pateldivyesh1323@gmail.com> Co-authored-by: neo773 <62795688+neo773@users.noreply.github.com> Co-authored-by: Mehul <mehulzr@gmail.com>

zomars added the core area: core, team members only label Aug 31, 2023

hariombalhara changed the title ~~Handle disabling of ORGANIZATIONS_ENABLED flag~~ Handle disabling of ORGANIZATIONS_ENABLED with 0 value as well Aug 31, 2023

hariombalhara changed the title ~~Handle disabling of ORGANIZATIONS_ENABLED with 0 value as well~~ Handle disabling of ORGANIZATIONS_ENABLED correctly. Aug 31, 2023

Handle disabling of ORGANIZATIONS_ENABLED flag

81116ab

hariombalhara force-pushed the fix/headers-redirect-logging branch from 4e5efd6 to 81116ab Compare August 31, 2023 10:41

hariombalhara commented Aug 31, 2023

View reviewed changes

hariombalhara requested a review from leog August 31, 2023 10:45

hariombalhara marked this pull request as ready for review August 31, 2023 10:45

hariombalhara changed the title ~~Handle disabling of ORGANIZATIONS_ENABLED correctly.~~ fix: Handle disabling of ORGANIZATIONS_ENABLED correctly. Aug 31, 2023

vercel bot had a problem deploying to Preview – ui August 31, 2023 10:45 Failure

vercel bot deployed to Preview – api August 31, 2023 10:48 View deployment

vercel bot deployed to Preview – cal-demo August 31, 2023 10:50 View deployment

vercel bot deployed to Preview – dev August 31, 2023 10:52 View deployment

leog approved these changes Aug 31, 2023

View reviewed changes

hariombalhara merged commit edc90e3 into main Aug 31, 2023
34 of 36 checks passed

hariombalhara deleted the fix/headers-redirect-logging branch August 31, 2023 14:18

sean-brydon pushed a commit that referenced this pull request Sep 1, 2023

Handle disabling of ORGANIZATIONS_ENABLED flag (#11041)

31dc23a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Handle disabling of ORGANIZATIONS_ENABLED correctly. #11041

fix: Handle disabling of ORGANIZATIONS_ENABLED correctly. #11041

hariombalhara commented Aug 31, 2023

vercel bot commented Aug 31, 2023 •

edited

github-actions bot commented Aug 31, 2023 •

edited

hariombalhara Aug 31, 2023

hariombalhara Aug 31, 2023

github-actions bot commented Aug 31, 2023

deploysentinel bot commented Aug 31, 2023 •

edited

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

leog left a comment

@@ @@ -333,44 +334,46 @@ const nextConfig = { @@
                         },
                       ],
                     },
-                    ...[

fix: Handle disabling of ORGANIZATIONS_ENABLED correctly. #11041

fix: Handle disabling of ORGANIZATIONS_ENABLED correctly. #11041

Conversation

hariombalhara commented Aug 31, 2023

What does this PR do?

Type of change

How should this be tested?

Mandatory Tasks

vercel bot commented Aug 31, 2023 • edited

github-actions bot commented Aug 31, 2023 • edited

hariombalhara Aug 31, 2023

Choose a reason for hiding this comment

hariombalhara Aug 31, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 31, 2023

📦 Next.js Bundle Analysis for @calcom/web

Seventeen Pages Changed Size

deploysentinel bot commented Aug 31, 2023 • edited

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

leog left a comment

Choose a reason for hiding this comment

vercel bot commented Aug 31, 2023 •

edited

github-actions bot commented Aug 31, 2023 •

edited

deploysentinel bot commented Aug 31, 2023 •

edited