chore: [app dir bootstrapping 9]: replace useSearchParams with useCompatSearchParams hook #12056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DmytroHryshyn is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
DmytroHryshyn
changed the title
4 tasks
DmytroHryshyn
force-pushed
the
intuita/useCompatSearchParams
branch
from
e6b3f01
to
3cd45f9
Compare
hbjORbj
force-pushed
the
intuita/useCompatSearchParams
branch
from
b398e2c
to
7e47aa8
Compare
|
Hey there, there is a merge conflict, can you take a look? |
github-actions
bot
added
the
🚨 merge conflict
grzpab
force-pushed
the
intuita/useCompatSearchParams
branch
2 times, most recently
from
bdb2c4c
to
7d8e2e4
Compare
grzpab
force-pushed
the
intuita/useCompatSearchParams
branch
from
7d8e2e4
to
08b6d70
Compare
zomars
approved these changes
Nov 15, 2023
Merge activity
|
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Nov 28, 2023
…patSearchParams hook (calcom#12056) Co-authored-by: zomars <zomars@me.com>
jakazzy
pushed a commit
to jakazzy/cal.com
that referenced
this pull request
Dec 5, 2023
…patSearchParams hook (calcom#12056) Co-authored-by: zomars <zomars@me.com>
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
…patSearchParams hook (calcom#12056) Co-authored-by: zomars <zomars@me.com>
zomars
added a commit
that referenced
this pull request
Jan 29, 2024
…patSearchParams hook (#12056) Co-authored-by: zomars <zomars@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Applies replace-use-search-params codemod to provide consistent hook behaviour between next@13.4.6 and next@13.5.4 versions.
Adds tests for useCompatSearchParams hook
Codemod impact: 46 files changed. Estimated time saving ~1h
useSearchParams in next@13.4.6 returns both
paramsandsearchParamswhen executed in Pages Router. On latest version of next js useSearchParams hook behaviour is same in Pages Router and App Router - it returns onlysearchParams,paramsare no more included.useCompatSearchParams is aimed to simplify migration by providing next@13.4.6 useSearchParams hook behaviour.
Requirement/Documentation
See navigation hooks comparison
Type of change
How should this be tested?
new useCompatSearchParams hook was covered with unit tests
Mandatory Tasks