fix: getting-started crash and build failure #12506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
hariombalhara
force-pushed
the
fix/getting-started-crash
branch
from
ea36565
to
db7c930
Compare
hariombalhara
force-pushed
the
fix/getting-started-crash
branch
from
db7c930
to
948e916
Compare
…ing-started-crash
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 338 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/23/2023 05:26:50am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 46b535e Started: 11/23/2023 05:19:59am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and select Question Checkbox Group required and select required
Retry 1 • Initial Attempt |
0% (0)0 / 247 runsfailed over last 7 days |
0.40% (1)1 / 247 runflaked over last 7 days |
📄 apps/web/playwright/insights.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Insights should be able to go to insights as members
Retry 1 • Initial Attempt |
0% (0)0 / 261 runsfailed over last 7 days |
3.45% (9)9 / 261 runsflaked over last 7 days |
|
Insights should test download button
Retry 2 • Retry 1 • Initial Attempt |
0.38% (1)1 / 261 runfailed over last 7 days |
3.07% (8)8 / 261 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization should be able to create an organization and complete onboarding
Retry 1 • Initial Attempt |
1.28% (1)1 / 78 runfailed over last 7 days |
96.15% (75)75 / 78 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Invitation (non verified)
Retry 1 • Initial Attempt |
1.30% (1)1 / 77 runfailed over last 7 days |
10.39% (8)8 / 77 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
17.95% (49)49 / 273 runsfailed over last 7 days |
77.66% (212)212 / 273 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
3.28% (9)9 / 274 runsfailed over last 7 days |
59.85% (164)164 / 274 runsflaked over last 7 days |
hariombalhara
changed the title
Closed
zomars
previously approved these changes
Nov 23, 2023
|
Is the e2e failure related to this? |
|
e2s are failing due to 404.tsx page not being used now somehow(due to app dir changes). I am fixing the 404 locator in the 2 failing tests for now. But we need to actually fix the 404 route later. |
2 tasks
zomars
approved these changes
Nov 23, 2023
hariombalhara
added a commit
that referenced
this pull request
Nov 24, 2023
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Nov 28, 2023
jakazzy
pushed a commit
to jakazzy/cal.com
that referenced
this pull request
Dec 5, 2023
hbjORbj
pushed a commit
to codemod-com/cal.com-demo
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix /getting-started crash.
Fixes #12503
Fixes #12502
It is possibly caused by #12056