fix: Dynamic duration was always overwritten with the default (30) #12444

emrysal · 2023-11-20T16:07:36Z

What does this PR do?

multipleDuration useEvent was never set in case of dynamic event - so couldn't be used in the booker store.

vercel · 2023-11-20T16:07:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 5, 2023 0:08am
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 5, 2023 0:08am
dev	❌ Failed (Inspect)			Dec 5, 2023 0:08am

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview	Dec 5, 2023 0:08am
cal-demo	⬜️ Ignored (Inspect)	Visit Preview	Dec 5, 2023 0:08am
qa	⬜️ Ignored (Inspect)	Visit Preview	Dec 5, 2023 0:08am
ui	⬜️ Ignored (Inspect)	Visit Preview	Dec 5, 2023 0:08am

github-actions · 2023-11-20T16:07:49Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

github-actions · 2023-11-20T16:25:45Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-11-20T16:26:14Z

Current Playwright Test Results Summary

✅ 336 Passing - ⚠️ 25 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/05/2023 12:15:52pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 2267e07

Started: 12/05/2023 12:08:24pm UTC

⚠️ Flakes

📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking with Seats User can create a seated event (2 seats as example) Retry 1 • Initial Attempt	1.88% (5) 5 / 266 runs failed over last 7 days	26.69% (71) 71 / 266 runs flaked over last 7 days

📄 apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

`null`	13 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-77.66% (-219) -219 / 282 runs failed over last 7 days	77.66% (219) 219 / 282 runs flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-77.30% (-218) -218 / 282 runs failed over last 7 days	77.66% (219) 219 / 282 runs flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-77.94% (-219) -219 / 281 runs failed over last 7 days	77.94% (219) 219 / 281 runs flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-77.94% (-219) -219 / 281 runs failed over last 7 days	77.94% (219) 219 / 281 runs flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-77.58% (-218) -218 / 281 runs failed over last 7 days	77.94% (219) 219 / 281 runs flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-78.21% (-219) -219 / 280 runs failed over last 7 days	78.21% (219) 219 / 280 runs flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-78.21% (-219) -219 / 280 runs failed over last 7 days	78.21% (219) 219 / 280 runs flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-78.21% (-219) -219 / 280 runs failed over last 7 days	78.21% (219) 219 / 280 runs flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-76.43% (-214) -214 / 280 runs failed over last 7 days	78.21% (219) 219 / 280 runs flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-79.27% (-218) -218 / 275 runs failed over last 7 days	79.64% (219) 219 / 275 runs flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-79.20% (-217) -217 / 274 runs failed over last 7 days	79.93% (219) 219 / 274 runs flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-22.79% (-62) -62 / 272 runs failed over last 7 days	53.68% (146) 146 / 272 runs flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes Retry 2 • Retry 1 • Initial Attempt	-29.95% (-56) -56 / 187 runs failed over last 7 days	56.68% (106) 106 / 187 runs flaked over last 7 days

📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and checkbox Question Checkbox Group required and checkbox required Retry 1 • Initial Attempt	0% (0) 0 / 285 runs failed over last 7 days	1.75% (5) 5 / 285 runs flaked over last 7 days

📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Multi email Question Phone required and Multi email not required Retry 1 • Initial Attempt	0.35% (1) 1 / 282 run failed over last 7 days	1.42% (4) 4 / 282 runs flaked over last 7 days

📄 apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Teams - NonOrg Can create a private team Retry 1 • Initial Attempt	0% (0) 0 / 294 runs failed over last 7 days	22.45% (66) 66 / 294 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 4 Flakes

Top 1 Common Error Messages

`null`	4 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 2 • Retry 1 • Initial Attempt	6.08% (18) 18 / 296 runs failed over last 7 days	88.85% (263) 263 / 296 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	2.71% (8) 8 / 295 runs failed over last 7 days	38.64% (114) 114 / 295 runs flaked over last 7 days
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	3.04% (9) 9 / 296 runs failed over last 7 days	51.69% (153) 153 / 296 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	3.04% (9) 9 / 296 runs failed over last 7 days	77.70% (230) 230 / 296 runs flaked over last 7 days

📄 apps/web/playwright/change-username.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Change username on settings User can change username Retry 1 • Initial Attempt	0.35% (1) 1 / 286 run failed over last 7 days	16.08% (46) 46 / 286 runs flaked over last 7 days

📄 apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Team Invitation (non verified) Retry 1 • Initial Attempt	2.05% (6) 6 / 293 runs failed over last 7 days	34.81% (102) 102 / 293 runs flaked over last 7 days
Team Invitation (verified) Retry 1 • Initial Attempt	0.34% (1) 1 / 293 run failed over last 7 days	5.12% (15) 15 / 293 runs flaked over last 7 days

📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization should be able to create an organization and complete onboarding Retry 1 • Initial Attempt	18.24% (54) 54 / 296 runs failed over last 7 days	60.47% (179) 179 / 296 runs flaked over last 7 days

View Detailed Build Results

Udit-takkar

@emrysal I am seeing wrong slots when i changed the duration from 30 to 60.

and when I tried to book the slot (10:30Am-11:30AM 60min). I am getting error

Could not book the meeting.
Some of the hosts are unavailable for booking.

http://localhost:3000/pro+free

'pro' has a google calendar connected which has a busy event till 2:00 PM
'free' doesn't have any calendar connected.

zomars

We got some type check uh-ohs in there

ThyMinimalDev

I believe type errors were not linked to this pr, double checking Udit comment before approving

double check

ThyMinimalDev · 2023-11-29T09:51:00Z

@emrysal I am seeing wrong slots when i changed the duration from 30 to 60.

and when I tried to book the slot (10:30Am-11:30AM 60min). I am getting error

Could not book the meeting. Some of the hosts are unavailable for booking.

http://localhost:3000/pro+free

'pro' has a google calendar connected which has a busy event till 2:00 PM 'free' doesn't have any calendar connected.

not sure to understand what you mean by wrong slots, it seems fine on my end ?

Udit-takkar · 2023-11-29T14:17:54Z

not sure to understand what you mean by wrong slots, it seems fine on my end ?

Steps to reproduce this bug locally

http://localhost:3000/pro+free

Connect google calendar in one of the account (pro )
Create a busy event from 8:30AM - 2PM

now go to http://localhost:3000/pro+free

When Duration is 30min slots start are 2:30, 3:00, 3:30 ..

Now change the duration to 60min and now the slots start at 9:30AM, 10:30AM .. and so on

It ignored the busy event in calendar till 2PM.

ThyMinimalDev · 2023-12-05T12:00:36Z

@Udit-takkar following the steps you describe, can't reproduce this error on both this branch and main branch, can you double check ?

Udit-takkar · 2023-12-06T13:09:48Z

I tried again today with a new calendar connection and i am still getting the same slots as the screenshot above.

supalarry · 2023-12-07T09:13:51Z

I also tried reproducing what Udit reported but could not. 30 and 60 minute slots start at the same time after booking event for the pro account on google calendar.

Before

30 minute slots

60 minute slots

After

I connected pro to google account and booked from 8:30am to 2pm

30 minute slots

60 minute slots

supalarry · 2023-12-07T09:21:09Z

packages/features/bookings/Booker/types.ts

+  /**
+   * Configures the selectable options for a multiDuration event type.
+   */
+  durationConfig?: number[];


Shall we name it durationOptions instead ? I find that word config implies a more complex configuration than just a set of possible duration values.

Udit-takkar · 2023-12-07T11:56:32Z

@supalarry Ok safe to merge then

zomars

Issues were addressed

…alcom#12444) Co-authored-by: Omar López <zomars@me.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>

fix: Dynamic duration was always overwritten with the default (30)

ac99684

zomars added core area: core, team members only devops labels Nov 20, 2023

vercel bot deployed to Preview – ai November 20, 2023 16:09 View deployment

vercel bot deployed to Preview – api November 20, 2023 16:10 View deployment

emrysal added 2 commits November 20, 2023 16:11

undefined -> null value change for duration with searchParams

a5e6148

queryParams is possibly undefined

827de0c

emrysal requested a review from sean-brydon November 20, 2023 16:13

vercel bot deployed to Preview – api November 20, 2023 16:20 View deployment

vercel bot deployed to Preview – dev November 20, 2023 16:27 View deployment

keithwillcode added booking-page area: booking page, public booking page, booker Medium priority Created by Linear-GitHub Sync labels Nov 21, 2023

keithwillcode requested a review from a team November 21, 2023 15:46

Udit-takkar reviewed Nov 22, 2023

View reviewed changes

Merge branch 'main' into bugfix/dynamic-duration-not-working

7036198

vercel bot deployed to Preview – ai November 27, 2023 17:57 View deployment

vercel bot deployed to Preview – api November 27, 2023 17:58 View deployment

vercel bot deployed to Preview – dev November 27, 2023 18:04 View deployment

zomars requested changes Nov 28, 2023

View reviewed changes

Merge branch 'main' into bugfix/dynamic-duration-not-working

4db9c0f

ThyMinimalDev previously approved these changes Nov 29, 2023

View reviewed changes

ThyMinimalDev self-requested a review November 29, 2023 09:30

vercel bot deployed to Preview – ai November 29, 2023 09:31 View deployment

vercel bot deployed to Preview – api November 29, 2023 09:32 View deployment

vercel bot deployed to Preview – dev November 29, 2023 09:37 View deployment

Merge branch 'main' into bugfix/dynamic-duration-not-working

2267e07

vercel bot deployed to Preview – ai December 5, 2023 12:01 View deployment

ThyMinimalDev requested a review from Udit-takkar December 5, 2023 12:02

vercel bot deployed to Preview – api December 5, 2023 12:05 View deployment

vercel bot had a problem deploying to Preview – dev December 5, 2023 12:08 Failure

supalarry reviewed Dec 7, 2023

View reviewed changes

zomars approved these changes Dec 11, 2023

View reviewed changes

zomars merged commit 565e21b into main Dec 11, 2023
41 of 42 checks passed

zomars deleted the bugfix/dynamic-duration-not-working branch December 11, 2023 23:07

Udit-takkar mentioned this pull request Feb 6, 2024

fix: Collective Events: Duration parameter in link not working #13523

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Dynamic duration was always overwritten with the default (30) #12444

fix: Dynamic duration was always overwritten with the default (30) #12444

emrysal commented Nov 20, 2023

vercel bot commented Nov 20, 2023 •

edited

github-actions bot commented Nov 20, 2023 •

edited

github-actions bot commented Nov 20, 2023 •

edited

deploysentinel bot commented Nov 20, 2023 •

edited

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Udit-takkar left a comment

zomars left a comment

ThyMinimalDev left a comment •

edited

ThyMinimalDev commented Nov 29, 2023

Udit-takkar commented Nov 29, 2023

ThyMinimalDev commented Dec 5, 2023 •

edited

Udit-takkar commented Dec 6, 2023

supalarry commented Dec 7, 2023

supalarry Dec 7, 2023

Udit-takkar commented Dec 7, 2023

zomars left a comment

fix: Dynamic duration was always overwritten with the default (30) #12444

fix: Dynamic duration was always overwritten with the default (30) #12444

Conversation

emrysal commented Nov 20, 2023

What does this PR do?

vercel bot commented Nov 20, 2023 • edited

github-actions bot commented Nov 20, 2023 • edited

github-actions bot commented Nov 20, 2023 • edited

📦 Next.js Bundle Analysis for @calcom/web

deploysentinel bot commented Nov 20, 2023 • edited

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Udit-takkar left a comment

Choose a reason for hiding this comment

zomars left a comment

Choose a reason for hiding this comment

ThyMinimalDev left a comment • edited

Choose a reason for hiding this comment

ThyMinimalDev commented Nov 29, 2023

Udit-takkar commented Nov 29, 2023

ThyMinimalDev commented Dec 5, 2023 • edited

Udit-takkar commented Dec 6, 2023

supalarry commented Dec 7, 2023

Before

30 minute slots

60 minute slots

After

30 minute slots

60 minute slots

supalarry Dec 7, 2023

Choose a reason for hiding this comment

Udit-takkar commented Dec 7, 2023

zomars left a comment

Choose a reason for hiding this comment

vercel bot commented Nov 20, 2023 •

edited

github-actions bot commented Nov 20, 2023 •

edited

github-actions bot commented Nov 20, 2023 •

edited

deploysentinel bot commented Nov 20, 2023 •

edited

ThyMinimalDev left a comment •

edited

ThyMinimalDev commented Dec 5, 2023 •

edited