Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Collective Events: Duration parameter in link not working #13523

Merged
merged 7 commits into from
Feb 13, 2024
Merged

fix: Collective Events: Duration parameter in link not working #13523

merged 7 commits into from
Feb 13, 2024

Conversation

Nis-Han
Copy link
Contributor

@Nis-Han Nis-Han commented Feb 3, 2024 •
edited
Loading

What does this PR do?

Fixes #13504

https://www.loom.com/share/1d37a04658a7453ca662bea38988b7ee?sid=447a9129-0905-48f3-a855-1513ba0ddb0c

Requirement/Documentation

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Run this branch on local and try doing this

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't checked if my PR needs changes to the documentation
  • I haven't added tests that prove my fix is effective or that my feature works

@vercel Vercel
Copy link

vercel bot commented Feb 3, 2024

@Nis-Han is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2024 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2024 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode added this to the v3.8 milestone Feb 3, 2024
@keithwillcode keithwillcode added High priority Created by Linear-GitHub Sync bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync labels Feb 3, 2024
@Udit-takkar Udit-takkar requested a review from a team February 6, 2024 08:01
Udit-takkar
Udit-takkar previously requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do something like Alex did for user booking pages #12444 ?

@keithwillcode keithwillcode marked this pull request as draft February 6, 2024 17:08
@Nis-Han
Copy link
Contributor Author

Nis-Han commented Feb 10, 2024 •
edited
Loading

can we do something like Alex did for user booking pages #12444 ?

Have made the changes and tested accordingly. (Mostly copied the relevant part)

There are some comments related to duration prop in Booker component that Alex left. Have copied that as well, as it might need a cleanup later.

@keithwillcode keithwillcode marked this pull request as ready for review February 10, 2024 10:15
@keithwillcode
Copy link
Contributor

@Nis-Han looks like there are some type checks failing

@Nis-Han
Merge branch 'main' into issue#13504
bcc42ec 
Amend: update `generateMetadata` method with new params for team/[slug]/[type] page
@Nis-Han
Copy link
Contributor Author

Nis-Han commented Feb 10, 2024

@Nis-Han looks like there are some type checks failing

fixed

@keithwillcode keithwillcode requested a review from a team February 12, 2024 06:09
Udit-takkar
Udit-takkar approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nis-Han LGTM 👍

@Udit-takkar Udit-takkar merged commit d4f41e8 into calcom:main Feb 13, 2024
30 of 38 checks passed
@Nis-Han Nis-Han deleted the issue#13504 branch February 16, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar approved these changes

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.

Collective Events: Duration parameter in link not working when changing it manually
5 participants
@Nis-Han @CLAassistant @keithwillcode @Udit-takkar @PeerRich