-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use destination calendar email #12821
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/13/2024 10:14:07am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 775ca2b Started: 02/13/2024 10:05:05am UTC
|
|
3 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and checkbox Question Multiple Email and checkbox not required
Retry 1 • Initial Attempt |
0.39% (1)1 / 254 runfailed over last 7 days |
4.72% (12)12 / 254 runsflaked over last 7 days |
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Number Question Multiple Email and Number not required
Retry 1 • Initial Attempt |
0% (0)0 / 253 runsfailed over last 7 days |
5.93% (15)15 / 253 runsflaked over last 7 days |
Booking With Multiple Email Question and Each Other Question Booking With Multiple email Question and phone Question Multiple email and Phone not required
Retry 1 • Initial Attempt |
0% (0)0 / 252 runsfailed over last 7 days |
5.16% (13)13 / 252 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Checkbox Group Question Long Text and Checkbox Group required
Retry 1 • Initial Attempt |
0% (0)0 / 261 runsfailed over last 7 days |
6.51% (17)17 / 261 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Webhook tests FORM_SUBMITTED on submitting user form, triggers user webhook
Retry 1 • Initial Attempt |
0% (0)0 / 265 runsfailed over last 7 days |
5.66% (15)15 / 265 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Phone Question and Each Other Question Booking With Select Question and Multi email Question Select required and Multi email required
Retry 1 • Initial Attempt |
0% (0)0 / 255 runsfailed over last 7 days |
6.67% (17)17 / 255 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and multiselect Question Checkbox Group required and multiselect text required
Retry 1 • Initial Attempt |
0% (0)0 / 262 runsfailed over last 7 days |
3.82% (10)10 / 262 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
0% (0)0 / 157 runsfailed over last 7 days |
49.04% (77)77 / 157 runsflaked over last 7 days |
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt |
11.59% (19)19 / 164 runsfailed over last 7 days |
51.83% (85)85 / 164 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Address Question and Each Other Question Booking With Address Question and select Question Address and select not required
Retry 1 • Initial Attempt |
0% (0)0 / 266 runsfailed over last 7 days |
5.26% (14)14 / 266 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and checkbox Question Radio and checkbox not required
Retry 1 • Initial Attempt |
0.38% (1)1 / 262 runfailed over last 7 days |
3.82% (10)10 / 262 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 268 runsfailed over last 7 days |
36.19% (97)97 / 268 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.75% (2)2 / 268 runsfailed over last 7 days |
44.78% (120)120 / 268 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This PR is being marked as stale due to inactivity. |
Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
@CarinaWolli Fixed Now. Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now 🙌🏻
Note sure if this is the right place to post this feedback, but neither [CAL-1684] (#3643) nor [CAL-499] (#5774) appear to be working for me on cal.com after enabling the new setting in my Event Types.
I have verified the new "Display 'Add to calendar' email as the organizer" toggle is checked on my event types, and I have tried toggling it on and off multiple times. All calendars are Google Calendars using Google Workspace accounts. |
@rthaut It works for me as expected I noticed that the email for your calendar matches the one on your Cal account. Have you made any recent changes, or what's the issue you're trying to resolve? |
@CarinaWolli is there a support mechanism other than GitHub tickets for working through this? I don't want to clutter up this PR if it is simply a misconfiguration issue on my part...
I don't understand how this could be. I have chosen my Event Types to go to calendars that are owned by other email addresses and are simply shared (via Google's Calendar sharing functionality) to the email address I use for my cal.com account.
After your response I did try re-adding my target calendars directly (i.e. I gave cal.com access to each calendar by logging in with the appropriate email address), and updating the "Add to calendar" setting of the Event Types. However, even with that change all invites and emails are still just using my cal.com email address.
I want certain Event Type links to create appointments on certain calendars. Additionally, I would like to avoid exposing the email address I use for cal.com to anyone scheduling events with me, and instead expose the email addresses associated those to the calendars. My use case is that I sub-contract for several companies, most of whom provide me with a Google workspace account for their domain. Through those companies I have multiple clients who I work with directly on behalf of the companies for whom I sub-contract. I want all of my clients to see my availability in one place, but I want them to schedule to the calendar/domain to which they are a client. I especially don't want those clients to have any way of finding my private email address/domain. |
@rthaut Sounds specific, would be best to reach out to our support go.cal.com/support. And make sure to add all this information 🙏 |
@rthaut just make sure to delete any old calendar integration and connect them again and then turn on the switch in the event type advanced settings. You would receive all the emails and events on the selected calendar and on the booking page also it would not mention your account's email |
Fixes: #3643
Fixes: #5774
How to test?
Check if email and calendar event is sent to calendar integration email and not account settings email.
Try different combinations:- outlook integration + team event type.. etc
Preference order:-
Event type Destination email > Account Email address
TODO
Could break core features