-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing userPrimaryEmail in workflows #13875
Conversation
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Graphite AutomationsA Graphite automation took an action on this PR • (02/26/24)1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer' |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 452 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/27/2024 10:12:43am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 048155b Started: 02/27/2024 10:04:35am UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Phone Question and Each Other Question Booking With Select Question and Number Question Select and Number not required
Retry 1 • Initial Attempt |
0% (0)0 / 179 runsfailed over last 7 days |
5.59% (10)10 / 179 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
3 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Checkbox Group Question Long Text required and Checkbox Group not required
Retry 1 • Initial Attempt |
0.57% (1)1 / 175 runfailed over last 7 days |
9.14% (16)16 / 175 runsflaked over last 7 days |
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Radio group Question Long Text and Radio group required
Retry 1 • Initial Attempt |
0% (0)0 / 173 runsfailed over last 7 days |
7.51% (13)13 / 173 runsflaked over last 7 days |
Booking With Long Text Question and Each Other Question Booking With Long Text Question and select Question Long Text required and select not required
Retry 1 • Initial Attempt |
0% (0)0 / 173 runsfailed over last 7 days |
10.98% (19)19 / 173 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0.58% (1)1 / 173 runfailed over last 7 days |
41.04% (71)71 / 173 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and multiselect Question Phone and multiselect text required
Retry 1 • Initial Attempt |
0% (0)0 / 186 runsfailed over last 7 days |
4.30% (8)8 / 186 runsflaked over last 7 days |
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Number Question Phone and Number required
Retry 1 • Initial Attempt |
0.54% (1)1 / 186 runfailed over last 7 days |
5.38% (10)10 / 186 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Address Question and Each Other Question Booking With Address Question and Radio group Question Address and Radio group not required
Retry 1 • Initial Attempt |
0% (0)0 / 182 runsfailed over last 7 days |
7.14% (13)13 / 182 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Long text Question Checkbox Group and Long text not required
Retry 1 • Initial Attempt |
0% (0)0 / 178 runsfailed over last 7 days |
6.18% (11)11 / 178 runsflaked over last 7 days |
📄 apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking With Multiple Email Question and Each Other Question Booking With Multiple email Question and phone Question Multiple email and Phone not required
Retry 1 • Initial Attempt |
0% (0)0 / 173 runsfailed over last 7 days |
5.78% (10)10 / 173 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Webhook tests Add webhook on event type config Booking rejected
Retry 1 • Initial Attempt |
0% (0)0 / 182 runsfailed over last 7 days |
1.65% (3)3 / 182 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix that in other places as well, you can search for scheduleEmailReminder
and in most of these places the sendTo
needs to fixed
@CarinaWolli I already fixed this in my previous PR. bookingInfo.organizer?.email is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good then 👏🏻
What does this PR do?
Fixes use userPrimaryEmail to send emails to
Probably missed in PR :- #12821
Type of change