Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing userPrimaryEmail in workflows #13875

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

Udit-takkar
Copy link
Contributor

What does this PR do?

Fixes use userPrimaryEmail to send emails to

Probably missed in PR :- #12821

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@graphite-app graphite-app bot requested a review from a team February 26, 2024 17:56
Copy link
Contributor

github-actions bot commented Feb 26, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 26, 2024
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 9:57am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 9:57am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 9:57am
qa ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 9:57am

Copy link

graphite-app bot commented Feb 26, 2024

Graphite Automations

A Graphite automation took an action on this PR • (02/26/24)

1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer'

Copy link
Contributor

github-actions bot commented Feb 26, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Feb 26, 2024

Current Playwright Test Results Summary

✅ 452 Passing - ⚠️ 11 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/27/2024 10:12:43am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 048155b

Started: 02/27/2024 10:04:35am UTC

⚠️ Flakes

📄   apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Select Question and Number Question Select and Number not required
Retry 1Initial Attempt
0% (0) 0 / 179 runs
failed over last 7 days
5.59% (10) 10 / 179 runs
flaked over last 7 days

📄   apps/web/playwright/booking/longTextQuestion.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Checkbox Group Question Long Text required and Checkbox Group not required
Retry 1Initial Attempt
0.57% (1) 1 / 175 run
failed over last 7 days
9.14% (16) 16 / 175 runs
flaked over last 7 days
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Radio group Question Long Text and Radio group required
Retry 1Initial Attempt
0% (0) 0 / 173 runs
failed over last 7 days
7.51% (13) 13 / 173 runs
flaked over last 7 days
Booking With Long Text Question and Each Other Question Booking With Long Text Question and select Question Long Text required and select not required
Retry 1Initial Attempt
0% (0) 0 / 173 runs
failed over last 7 days
10.98% (19) 19 / 173 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
0.58% (1) 1 / 173 run
failed over last 7 days
41.04% (71) 71 / 173 runs
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and multiselect Question Phone and multiselect text required
Retry 1Initial Attempt
0% (0) 0 / 186 runs
failed over last 7 days
4.30% (8) 8 / 186 runs
flaked over last 7 days
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Number Question Phone and Number required
Retry 1Initial Attempt
0.54% (1) 1 / 186 run
failed over last 7 days
5.38% (10) 10 / 186 runs
flaked over last 7 days

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Radio group Question Address and Radio group not required
Retry 1Initial Attempt
0% (0) 0 / 182 runs
failed over last 7 days
7.14% (13) 13 / 182 runs
flaked over last 7 days

📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Long text Question Checkbox Group and Long text not required
Retry 1Initial Attempt
0% (0) 0 / 178 runs
failed over last 7 days
6.18% (11) 11 / 178 runs
flaked over last 7 days

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple email Question and phone Question Multiple email and Phone not required
Retry 1Initial Attempt
0% (0) 0 / 173 runs
failed over last 7 days
5.78% (10) 10 / 173 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Webhook tests Add webhook on event type config Booking rejected
Retry 1Initial Attempt
0% (0) 0 / 182 runs
failed over last 7 days
1.65% (3) 3 / 182 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix that in other places as well, you can search for scheduleEmailReminder and in most of these places the sendTo needs to fixed

@Udit-takkar
Copy link
Contributor Author

scheduleEmailReminder

@CarinaWolli I already fixed this in my previous PR. bookingInfo.organizer?.email is email: booking?.userPrimaryEmail ?? booking.user.email,

Screenshot 2024-02-27 at 2 21 12 PM

Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good then 👏🏻

@CarinaWolli CarinaWolli merged commit 80080dd into main Feb 27, 2024
38 of 39 checks passed
@CarinaWolli CarinaWolli deleted the fix/missing-host-email branch February 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants