Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make private URLs easier to copy-paste from web app #13018

Merged
merged 6 commits into from
Jan 4, 2024
Merged

feat: Make private URLs easier to copy-paste from web app #13018

merged 6 commits into from
Jan 4, 2024

Conversation

riddhesh-mahajan
Copy link
Contributor

What does this PR do?

Adds private link copy icon on /event-types page. Icon will be visible if private url is enabled for a specific event.

Fixes #12996

Private link copy

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Edit event
  • Go to Advanced menu
  • Enable private url
  • Go back to /event-types page

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2024

@riddhesh-mahajan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

PeerRich
PeerRich previously approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@PeerRich PeerRich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if an incognito icon would make sense here:

CleanShot 2024-01-03 at 17 08 58@2x

svg: https://github.com/calcom/cal.com/assets/8019099/36237e55-40ab-46b3-9fd3-5d8f517a588a
incognito

@PeerRich
Copy link
Member

PeerRich commented Jan 3, 2024

I wonder if an incognito icon would make sense here:

CleanShot 2024-01-03 at 17 08 58@2x

svg: calcom/cal.com/assets/8019099/36237e55-40ab-46b3-9fd3-5d8f517a588a incognito

or the venecian mask from lucide icons:
https://lucide.dev/icons/venetian-mask
venetian-mask

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work labels Jan 3, 2024
@riddhesh-mahajan
Copy link
Contributor Author

I wonder if an incognito icon would make sense here:

venecian mask icon would be better

@PeerRich PeerRich merged commit 3791af8 into calcom:main Jan 4, 2024
18 of 25 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees
No one assigned
Labels
Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make private URLs easier to copy-paste from web app
2 participants
@riddhesh-mahajan @PeerRich