Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: API v1 slot return regression fix #13379

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

alishaz-polymath
Copy link
Member

What does this PR do?

This PR fixes a regression caused by a missing key within the availability object when returning slots without a timezone.

Fixes #13376

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview Jan 24, 2024 6:27am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 6:27am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 6:27am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jan 24, 2024 6:27am
cal-demo ⬜️ Ignored (Inspect) Jan 24, 2024 6:27am
calcom-web-canary ⬜️ Ignored (Inspect) Jan 24, 2024 6:27am
ui ⬜️ Ignored (Inspect) Jan 24, 2024 6:27am

@alishaz-polymath alishaz-polymath requested a review from a team January 24, 2024 06:16
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added api area: API, enterprise API, access token, OAuth enterprise area: enterprise, audit log, organisation, SAML, SSO foundation High priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jan 24, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Jan 24, 2024
@alishaz-polymath alishaz-polymath removed 🐛 bug Something isn't working enterprise area: enterprise, audit log, organisation, SAML, SSO core area: core, team members only foundation labels Jan 24, 2024
@sean-brydon sean-brydon enabled auto-merge (squash) January 24, 2024 06:22
Copy link

deploysentinel bot commented Jan 24, 2024

Current Playwright Test Results Summary

✅ 84 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/24/2024 07:01:04am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: fb8ff6d

Started: 01/24/2024 06:57:10am UTC

⚠️ Flakes

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 2Retry 1Initial Attempt
37.62% (38) 38 / 101 runs
failed over last 7 days
36.63% (37) 37 / 101 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 1Initial Attempt
1.51% (5) 5 / 332 runs
failed over last 7 days
7.23% (24) 24 / 332 runs
flaked over last 7 days
Stripe integration When event is paid and confirmed Cancelled paid booking should be refunded
Retry 1Initial Attempt
2.15% (7) 7 / 325 runs
failed over last 7 days
2.15% (7) 7 / 325 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address
Retry 1Initial Attempt
1.05% (2) 2 / 191 runs
failed over last 7 days
13.09% (25) 25 / 191 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@alishaz-polymath alishaz-polymath added this to the v3.8 milestone Jan 24, 2024
@sean-brydon sean-brydon merged commit 00a2a3d into main Jan 24, 2024
38 of 39 checks passed
@sean-brydon sean-brydon deleted the fix/slots-api-regression branch January 24, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3008] API: /slots returns inconsistently if you omit timeZone
3 participants