fix: don't display setup page icon for these apps #13537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 440 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/06/2024 04:08:51am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: de7e639 Started: 02/06/2024 04:03:25am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and checkbox group Question Multiple Email required and checkbox group required
Retry 1 • Initial Attempt |
3.13% (8)8 / 256 runsfailed over last 7 days |
5.86% (15)15 / 256 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and select Question Long Text and select required
Retry 1 • Initial Attempt |
0.44% (1)1 / 228 runfailed over last 7 days |
3.51% (8)8 / 228 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Short text question Long Text and Short text required
Retry 1 • Initial Attempt |
0% (0)0 / 227 runsfailed over last 7 days |
4.41% (10)10 / 227 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
4.66% (11)11 / 236 runsfailed over last 7 days |
39.83% (94)94 / 236 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Radio group Question Checkbox Group required and Radio group required
Retry 1 • Initial Attempt |
0.42% (1)1 / 237 runfailed over last 7 days |
4.22% (10)10 / 237 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
3.63% (9)9 / 248 runsfailed over last 7 days |
2.42% (6)6 / 248 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Radio and Address not required
Retry 1 • Initial Attempt |
0.42% (1)1 / 237 runfailed over last 7 days |
5.06% (12)12 / 237 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and select Question Address and select not required
Retry 1 • Initial Attempt |
0.41% (1)1 / 245 runfailed over last 7 days |
4.08% (10)10 / 245 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and select Question Phone and select required
Retry 1 • Initial Attempt |
0.42% (1)1 / 239 runfailed over last 7 days |
5.86% (14)14 / 239 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user enabling recurring event comes with default options
Retry 1 • Initial Attempt |
0% (0)0 / 261 runsfailed over last 7 days |
13.03% (34)34 / 261 runsflaked over last 7 days |
|
Event Types tests -- future user Different Locations Tests Can add Organzer Phone Number location and book with it
Retry 1 • Initial Attempt |
0.38% (1)1 / 261 runfailed over last 7 days |
3.83% (10)10 / 261 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 249 runsfailed over last 7 days |
25.30% (63)63 / 249 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 2 • Retry 1 • Initial Attempt |
2.35% (6)6 / 255 runsfailed over last 7 days |
14.12% (36)36 / 255 runsflaked over last 7 days |
Udit-takkar
commented
Feb 5, 2024
| <Settings className="text-default h-4 w-4" aria-hidden="true" /> | ||
| </Link> | ||
| {!hideSettingsIcon && ( | ||
| <Link href={`/apps/${app.slug}/setup`} className="absolute right-4 top-4"> |
There was a problem hiding this comment.
There is no setup page required
for these apps
sean-brydon
previously approved these changes
Feb 5, 2024
packages/app-store/fathom/components/EventTypeAppCardInterface.tsx
Outdated
Show resolved
Hide resolved
packages/app-store/ga4/components/EventTypeAppCardInterface.tsx
Outdated
Show resolved
Hide resolved
packages/app-store/gtm/components/EventTypeAppCardInterface.tsx
Outdated
Show resolved
Hide resolved
packages/app-store/matomo/components/EventTypeAppCardInterface.tsx
Outdated
Show resolved
Hide resolved
packages/app-store/metapixel/components/EventTypeAppCardInterface.tsx
Outdated
Show resolved
Hide resolved
packages/app-store/plausible/components/EventTypeAppCardInterface.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
https://threads.com/messages/36061128-87fb-48a0-b9c1-fd67f9507c06?messageID=87c8a470-4865-416f-a282-12dae98c916c
AFTER:-
Type of change