fix: amend user password migration #13662
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
api
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Graphite AutomationsA Graphite automation took an action on this PR • (02/13/24)1 reviewer was added based on Keith Williams's automation, 'Add foundation team as reviewer' |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
keithwillcode
approved these changes
Feb 13, 2024
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/13/2024 06:39:14pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 5fc30e1 Started: 02/13/2024 06:30:08pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Radio group Question Booking With Multiple Email Question and Short text question Multiple Email required and Short text required
Retry 1 • Initial Attempt |
0% (0)0 / 270 runsfailed over last 7 days |
3.70% (10)10 / 270 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and checkbox Question Select required and checkbox required
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 274 runsfailed over last 7 days |
3.65% (10)10 / 274 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Phone Question Long Text and Phone required
Retry 1 • Initial Attempt |
0% (0)0 / 278 runsfailed over last 7 days |
5.76% (16)16 / 278 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and checkbox Question Radio and checkbox not required
Retry 1 • Initial Attempt |
0.36% (1)1 / 281 runfailed over last 7 days |
3.91% (11)11 / 281 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Login and logout tests -- legacy Login flow validations -- legacy Should warn when user does not exist
Retry 1 • Initial Attempt |
0% (0)0 / 272 runsfailed over last 7 days |
4.41% (12)12 / 272 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and checkbox Question Checkbox Group required and checkbox required
Retry 1 • Initial Attempt |
0% (0)0 / 282 runsfailed over last 7 days |
6.38% (18)18 / 282 runsflaked over last 7 days |
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Long text Question Checkbox Group and Long text not required
Retry 1 • Initial Attempt |
0% (0)0 / 281 runsfailed over last 7 days |
4.98% (14)14 / 281 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and multiselect Question Phone and multiselect text required
Retry 1 • Initial Attempt |
0% (0)0 / 285 runsfailed over last 7 days |
4.91% (14)14 / 285 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Short text question Phone required and Short text not required
Retry 1 • Initial Attempt |
0.35% (1)1 / 283 runfailed over last 7 days |
5.65% (16)16 / 283 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Checkbox Group Question Address required and checkbox group required
Retry 1 • Initial Attempt |
0.69% (2)2 / 290 runsfailed over last 7 days |
5.86% (17)17 / 290 runsflaked over last 7 days |
|
Booking With Address Question and Each Other Question Booking With Address Question and Number Question Address required and Number required
Retry 1 • Initial Attempt |
0% (0)0 / 286 runsfailed over last 7 days |
3.85% (11)11 / 286 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 2 • Retry 1 • Initial Attempt |
0.70% (2)2 / 284 runsfailed over last 7 days |
14.44% (41)41 / 284 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0.69% (2)2 / 291 runsfailed over last 7 days |
52.92% (154)154 / 291 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-114.07% (-154)-154 / 135 runsfailed over last 7 days |
114.81% (155)155 / 135 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-114.18% (-153)-153 / 134 runsfailed over last 7 days |
114.18% (153)153 / 134 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-114.18% (-153)-153 / 134 runsfailed over last 7 days |
114.18% (153)153 / 134 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-114.18% (-153)-153 / 134 runsfailed over last 7 days |
114.18% (153)153 / 134 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-113.43% (-152)-152 / 134 runsfailed over last 7 days |
113.43% (152)152 / 134 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-113.43% (-152)-152 / 134 runsfailed over last 7 days |
113.43% (152)152 / 134 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-114.29% (-152)-152 / 133 runsfailed over last 7 days |
114.29% (152)152 / 133 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user enabling recurring event comes with default options
Retry 1 • Initial Attempt |
0% (0)0 / 290 runsfailed over last 7 days |
3.79% (11)11 / 290 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0% (0)0 / 293 runsfailed over last 7 days |
12.97% (38)38 / 293 runsflaked over last 7 days |
📄 apps/web/playwright/organization/across-org/across-org.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user1NotMemberOfOrg1 is part of team1MemberOfOrg1 EventTypes listing should show correct link for user events and team1MemberOfOrg1's events
Retry 1 • Initial Attempt |
1.05% (3)3 / 287 runsfailed over last 7 days |
11.50% (33)33 / 287 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.69% (2)2 / 289 runsfailed over last 7 days |
45.33% (131)131 / 289 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
0% (0)0 / 178 runsfailed over last 7 days |
51.69% (92)92 / 178 runsflaked over last 7 days |
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
11.35% (21)21 / 185 runsfailed over last 7 days |
54.05% (100)100 / 185 runsflaked over last 7 days |
zomars
commented
Feb 13, 2024
Comment on lines
+29
to
+30
| -- TODO for next migration. | ||
| -- ALTER TABLE "users" DROP COLUMN "password"; |
|
HI @zomars The password column is still being dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?