refactor: migrates user password to it's own table #13628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
keithwillcode
added
api
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/12/2024 04:33:19pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: fdf4f94 Started: 02/12/2024 04:24:08pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple email Question and phone Question Multiple email required and Phone required
Retry 1 • Initial Attempt |
0% (0)0 / 284 runsfailed over last 7 days |
6.34% (18)18 / 284 runsflaked over last 7 days |
📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user -- legacy Time slots should be reserved when selected
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 282 runsfailed over last 7 days |
4.26% (12)12 / 282 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and checkbox group Question Select required and checkbox group required
Retry 1 • Initial Attempt |
0% (0)0 / 286 runsfailed over last 7 days |
4.55% (13)13 / 286 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Select Question and Long text Question Select required and Long text required
Retry 1 • Initial Attempt |
0% (0)0 / 285 runsfailed over last 7 days |
3.51% (10)10 / 285 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Phone Question Checkbox Group and Phone not required
Retry 1 • Initial Attempt |
0.34% (1)1 / 296 runfailed over last 7 days |
5.07% (15)15 / 296 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Long text Question Radio and Long text not required
Retry 1 • Initial Attempt |
0% (0)0 / 292 runsfailed over last 7 days |
7.88% (23)23 / 292 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Webhook tests BOOKING_REQUESTED can book an event that requires confirmation and get a booking requested event
Retry 1 • Initial Attempt |
0% (0)0 / 297 runsfailed over last 7 days |
0.34% (1)1 / 297 runflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
0.64% (2)2 / 314 runsfailed over last 7 days |
10.83% (34)34 / 314 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0.66% (2)2 / 301 runsfailed over last 7 days |
51.83% (156)156 / 301 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-109.09% (-156)-156 / 143 runsfailed over last 7 days |
109.09% (156)156 / 143 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-109.15% (-155)-155 / 142 runsfailed over last 7 days |
109.15% (155)155 / 142 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-109.15% (-155)-155 / 142 runsfailed over last 7 days |
109.15% (155)155 / 142 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-108.45% (-154)-154 / 142 runsfailed over last 7 days |
108.45% (154)154 / 142 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-109.15% (-155)-155 / 142 runsfailed over last 7 days |
109.15% (155)155 / 142 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-108.45% (-154)-154 / 142 runsfailed over last 7 days |
108.45% (154)154 / 142 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-108.45% (-154)-154 / 142 runsfailed over last 7 days |
108.45% (154)154 / 142 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.67% (2)2 / 299 runsfailed over last 7 days |
43.48% (130)130 / 299 runsflaked over last 7 days |
zomars
commented
Feb 10, 2024
| requestedUser: | ||
| /** Don't leak the password */ | ||
| exclude(user, ["password"]), | ||
| requestedUser: user, |
There was a problem hiding this comment.
No need to exclude anymore
Comment on lines
+20
to
+27
| -- Inserts current user password into new table | ||
| INSERT INTO | ||
| "UserPassword" ("hash", "userId") | ||
| SELECT | ||
| u."password", | ||
| u.id | ||
| FROM | ||
| users u; |
There was a problem hiding this comment.
This step is to ensure no data is lost
sean-brydon
reviewed
Feb 10, 2024
packages/prisma/migrations/20240209223121_adds_user_password/migration.sql
Outdated
Show resolved
Hide resolved
keithwillcode
approved these changes
Feb 12, 2024
packages/prisma/migrations/20240209223121_adds_user_password/migration.sql
Show resolved
Hide resolved
This was referenced Feb 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #13002 #13549
Type of change
How should this be tested?
Mandatory Tasks