Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: UserPassword #13680

Merged
merged 1 commit into from
Feb 14, 2024
Merged

revert: UserPassword #13680

merged 1 commit into from
Feb 14, 2024

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Feb 14, 2024

What does this PR do?

reverts #13628

Removes UserPassword, we probably have to address our migration history as well to account for an unknown migration in the history.

@emrysal emrysal requested review from keithwillcode and a team February 14, 2024 12:17
Copy link
Contributor

github-actions bot commented Feb 14, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added the ❗️ migrations contains migration files label Feb 14, 2024
@keithwillcode keithwillcode added core area: core, team members only foundation labels Feb 14, 2024
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 0:23am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Feb 14, 2024 0:23am
calcom-web-canary ⬜️ Ignored (Inspect) Feb 14, 2024 0:23am
qa ⬜️ Ignored (Inspect) Feb 14, 2024 0:23am

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. works fine now

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Feb 14, 2024

Current Playwright Test Results Summary

✅ 447 Passing - ⚠️ 8 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/14/2024 12:34:41pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 58bc228

Started: 02/14/2024 12:25:57pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Checkbox Group Question Long Text required and Checkbox Group not required
Retry 1Initial Attempt
0% (0) 0 / 227 runs
failed over last 7 days
6.61% (15) 15 / 227 runs
flaked over last 7 days

📄   apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Select Question and checkbox Question Select required and checkbox required
Retry 1Initial Attempt
0% (0) 0 / 226 runs
failed over last 7 days
4.42% (10) 10 / 226 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
0.88% (2) 2 / 226 runs
failed over last 7 days
45.13% (102) 102 / 226 runs
flaked over last 7 days

📄   apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Number Question Radio and Number not required
Retry 1Initial Attempt
0% (0) 0 / 227 runs
failed over last 7 days
6.61% (15) 15 / 227 runs
flaked over last 7 days

📄   apps/web/playwright/insights.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Insights should test download button
Retry 1Initial Attempt
0% (0) 0 / 231 runs
failed over last 7 days
9.52% (22) 22 / 231 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email matching orgAutoAcceptEmail and a Verified Organization Team Invitation
Retry 1Initial Attempt
0.43% (1) 1 / 231 run
failed over last 7 days
9.52% (22) 22 / 231 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
10.95% (23) 23 / 210 runs
failed over last 7 days
53.81% (113) 113 / 210 runs
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Phone required and Address not required
Retry 1Initial Attempt
2.07% (5) 5 / 241 runs
failed over last 7 days
7.05% (17) 17 / 241 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal enabled auto-merge (squash) February 14, 2024 12:29
@emrysal emrysal merged commit 0a68c6d into main Feb 14, 2024
38 checks passed
@emrysal emrysal deleted the revert/user-password-table branch February 14, 2024 12:36
zomars added a commit that referenced this pull request Feb 14, 2024
emrysal pushed a commit that referenced this pull request Feb 14, 2024
* Revert "revert: UserPassword (#13680)"

This reverts commit 0a68c6d.

* fix: avoid updates for possible missing passwords
ThyMinimalDev added a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only foundation ❗️ migrations contains migration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants