Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to fix update email flaky test #13727

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

Udit-takkar
Copy link
Contributor

What does this PR do?

Fixes

Screenshot 2024-02-16 at 6 28 19 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@graphite-app graphite-app bot requested a review from a team February 16, 2024 13:01
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 16, 2024
await page.goto("/settings/my-account/profile");
const emailInputUpdated = page.getByTestId("profile-form-email");
const emailInputUpdated = await page.getByTestId("profile-form-email");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added await here and going to profile after /event-types

Copy link

graphite-app bot commented Feb 16, 2024

Graphite Automations

A Graphite automation took an action on this PR • (02/16/24)

1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer'

@vercel vercel bot temporarily deployed to Preview – api February 16, 2024 13:06 Inactive
@Udit-takkar Udit-takkar added this to the v3.9 milestone Feb 16, 2024
Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 1:11pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Feb 16, 2024 1:11pm
calcom-web-canary ⬜️ Ignored (Inspect) Feb 16, 2024 1:11pm

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Feb 16, 2024

Current Playwright Test Results Summary

✅ 447 Passing - ⚠️ 19 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/16/2024 01:22:10pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: da47d61

Started: 02/16/2024 01:12:52pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Address Question Multiple Email and Address not required
Retry 1Initial Attempt
0.43% (1) 1 / 234 run
failed over last 7 days
2.99% (7) 7 / 234 runs
flaked over last 7 days
Booking With Multiple Email Question and Each Other Question Booking With Multiple email Question and phone Question Multiple email and Phone not required
Retry 1Initial Attempt
0.43% (1) 1 / 233 run
failed over last 7 days
5.58% (13) 13 / 233 runs
flaked over last 7 days
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Radio group Question Booking With Multiple Email Question and select Question Multiple Email and select not required
Retry 1Initial Attempt
0% (0) 0 / 233 runs
failed over last 7 days
5.58% (13) 13 / 233 runs
flaked over last 7 days

📄   apps/web/playwright/booking/longTextQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Phone Question Long Text and Phone required
Retry 1Initial Attempt
0% (0) 0 / 233 runs
failed over last 7 days
5.15% (12) 12 / 233 runs
flaked over last 7 days
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Radio group Question Long Text required and Radio group not required
Retry 1Initial Attempt
0% (0) 0 / 232 runs
failed over last 7 days
7.33% (17) 17 / 232 runs
flaked over last 7 days

📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Radio group Question Checkbox Group required and Radio group required
Retry 1Initial Attempt
0% (0) 0 / 236 runs
failed over last 7 days
7.63% (18) 18 / 236 runs
flaked over last 7 days
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and select Question Checkbox Group and select not required
Retry 1Initial Attempt
0% (0) 0 / 233 runs
failed over last 7 days
4.72% (11) 11 / 233 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration When event is paid and confirmed Paid and confirmed booking should be able to be rescheduled
Retry 1Initial Attempt
3.33% (8) 8 / 240 runs
failed over last 7 days
4.58% (11) 11 / 240 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1Initial Attempt
0% (0) 0 / 247 runs
failed over last 7 days
6.48% (16) 16 / 247 runs
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Number Question Phone and Number required
Retry 1Initial Attempt
0% (0) 0 / 242 runs
failed over last 7 days
4.13% (10) 10 / 242 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
-4% (-10) -10 / 250 runs
failed over last 7 days
54.80% (137) 137 / 250 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-97.56% (-120) -120 / 123 runs
failed over last 7 days
101.63% (125) 125 / 123 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-105.08% (-124) -124 / 118 runs
failed over last 7 days
105.08% (124) 124 / 118 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-105.08% (-124) -124 / 118 runs
failed over last 7 days
105.08% (124) 124 / 118 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-105.08% (-124) -124 / 118 runs
failed over last 7 days
105.08% (124) 124 / 118 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-105.08% (-124) -124 / 118 runs
failed over last 7 days
105.08% (124) 124 / 118 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-105.08% (-124) -124 / 118 runs
failed over last 7 days
105.08% (124) 124 / 118 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-105.98% (-124) -124 / 117 runs
failed over last 7 days
105.98% (124) 124 / 117 runs
flaked over last 7 days

📄   apps/web/playwright/organization/across-org/across-org.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user1NotMemberOfOrg1 is part of team1MemberOfOrg1 EventTypes listing should show correct link for user events and team1MemberOfOrg1's events
Retry 1Initial Attempt
0% (0) 0 / 249 runs
failed over last 7 days
16.47% (41) 41 / 249 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode merged commit e1b10b4 into main Feb 16, 2024
36 of 38 checks passed
@keithwillcode keithwillcode deleted the fix/flaky-test branch February 16, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants