fix: sdk action events #13755
Merged
fix: sdk action events #13755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite AutomationsA Graphite automation took an action on this PR • (02/19/24)1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer' |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/21/2024 06:59:30pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f050508 Started: 02/21/2024 06:49:55pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and checkbox Question Multiple Email required and checkbox required
Retry 1 • Initial Attempt |
0.41% (1)1 / 244 runfailed over last 7 days |
7.38% (18)18 / 244 runsflaked over last 7 days |
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Number Question Multiple Email and Number not required
Retry 1 • Initial Attempt |
0% (0)0 / 242 runsfailed over last 7 days |
4.96% (12)12 / 242 runsflaked over last 7 days |
📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
prefill -- future logged in
Retry 1 • Initial Attempt |
0% (0)0 / 244 runsfailed over last 7 days |
5.74% (14)14 / 244 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Phone Question Select required and select required
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 258 runsfailed over last 7 days |
5.43% (14)14 / 258 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Radio group Question Long Text and Radio group required
Retry 1 • Initial Attempt |
0% (0)0 / 241 runsfailed over last 7 days |
6.22% (15)15 / 241 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and select Question Long Text required and select not required
Retry 1 • Initial Attempt |
0% (0)0 / 240 runsfailed over last 7 days |
6.25% (15)15 / 240 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Number Question Checkbox Group required and Number required
Retry 1 • Initial Attempt |
0% (0)0 / 248 runsfailed over last 7 days |
4.03% (10)10 / 248 runsflaked over last 7 days |
📄 apps/web/playwright/insights.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Insights should test download button
Retry 1 • Initial Attempt |
0% (0)0 / 258 runsfailed over last 7 days |
4.26% (11)11 / 258 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 264 runsfailed over last 7 days |
36.74% (97)97 / 264 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1 • Initial Attempt |
0.38% (1)1 / 261 runfailed over last 7 days |
1.53% (4)4 / 261 runsflaked over last 7 days |
📄 apps/web/playwright/settings/upload-avatar.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
UploadAvatar can upload an image
Retry 1 • Initial Attempt |
1.51% (4)4 / 265 runsfailed over last 7 days |
4.15% (11)11 / 265 runsflaked over last 7 days |
📄 apps/web/playwright/app-store.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
App Store - Authed -- legacy Installed Apps - Navigation
Retry 1 • Initial Attempt |
0% (0)0 / 260 runsfailed over last 7 days |
0.38% (1)1 / 260 runflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
1.14% (3)3 / 264 runsfailed over last 7 days |
41.67% (110)110 / 264 runsflaked over last 7 days |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
CarinaWolli
reviewed
Feb 20, 2024
packages/features/bookings/Booker/components/hooks/useBookings.ts
Outdated
Show resolved
Hide resolved
CarinaWolli
reviewed
Feb 21, 2024
| if (res.status >= 200 && res.status < 300) { | ||
| // tested by apps/web/playwright/booking-pages.e2e.ts | ||
| sdkActionManager?.fire("bookingCancelled", { | ||
| ...bookingCancelledEventProps, | ||
| booking: bookingWithCancellationReason, |
There was a problem hiding this comment.
added missing cancellation reason to booking
CarinaWolli
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
On booking success page sdkActionManager fires 'bookingSuccessful' event in useEffect so event when you click on cancel event 'bookingSuccessful' is fired.
Added more events for cancel and reschedule.
https://calcominc.slack.com/archives/C06988PE6CX/p1708099745580649?thread_ts=1708095071.972989&cid=C06988PE6CX
Type of change
How to test?
Go to packages/embeds/embed-react and run yarn dev
Try Booking any event type and check the console logs. you should see events like CAL::bookingSuccessful, CAL::bookingCancelled