Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: API builds after rename #14319

Conversation

zomars
Copy link
Member

@zomars zomars commented Apr 3, 2024

What does this PR do?

Fixes #14318

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

linear bot commented Apr 3, 2024

@graphite-app graphite-app bot requested a review from a team April 3, 2024 22:28
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working labels Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added the 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand label Apr 3, 2024
@keithwillcode keithwillcode added core area: core, team members only foundation labels Apr 3, 2024
@zomars zomars changed the title Fix: API builds after rename fixes: API builds after rename Apr 3, 2024
@zomars zomars enabled auto-merge (squash) April 3, 2024 22:29
Copy link

graphite-app bot commented Apr 3, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/03/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 10:30pm

Copy link
Contributor

github-actions bot commented Apr 3, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 3, 2024

Current Playwright Test Results Summary

✅ 300 Passing - ⚠️ 6 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/03/2024 10:41:32pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 95ddcf8

Started: 04/03/2024 10:38:08pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1Initial Attempt
1.02% (2) 2 / 196 runs
failed over last 7 days
18.37% (36) 36 / 196 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to a Team inside organization
Retry 2Retry 1Initial Attempt
1.39% (3) 3 / 216 runs
failed over last 7 days
12.96% (28) 28 / 216 runs
flaked over last 7 days
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done nonexisting user is invited to a team inside organization
Retry 1Initial Attempt
0% (0) 0 / 20 runs
failed over last 7 days
5% (1) 1 / 20 run
flaked over last 7 days

📄   apps/web/playwright/team/team-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Team Invitation (non verified)
Retry 1Initial Attempt
0% (0) 0 / 212 runs
failed over last 7 days
6.13% (13) 13 / 212 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
5.88% (12) 12 / 204 runs
failed over last 7 days
28.92% (59) 59 / 204 runs
flaked over last 7 days

📄   apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Signup Flow Test Signup with valid (non premium) username
Retry 1Initial Attempt
0.47% (1) 1 / 213 run
failed over last 7 days
4.69% (10) 10 / 213 runs
flaked over last 7 days

View Detailed Build Results


@zomars zomars changed the title fixes: API builds after rename fix: API builds after rename Apr 3, 2024
@zomars zomars merged commit 7421cea into main Apr 3, 2024
38 of 42 checks passed
@zomars zomars deleted the zomars/cal-3355-purchaseteamsubscription-rename-is-causing-api-v1-builds-to branch April 3, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working core area: core, team members only foundation 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3355] purchaseTeamSubscription rename is causing API v1 builds to fail
4 participants